From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5DE26CE32; Mon, 13 Apr 2026 16:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097767; cv=none; b=pOXYxspSaIBzmW1U542+jJ+q3By6BlCu28BP9bgbnaWBXL3+5DlHgCXDmKUA0Xse9GumbhLgemN2MyaWNukmGMNsSvG58dits9U52GxQcF8cvpTSilsmvX7nODyA6fIvTqyJuleArYU0NLaZJnH1cti8pC5Hh0lYQM8BmKERYbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097767; c=relaxed/simple; bh=0wQEu5BE5XsDbsSV+RDaFyd0VeRYEt5s1+eiKKtrf74=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=naRLj+jMfS/ZtqYhLQ26DX3w2VYbdjsFCXO86BcQJIukCaf9ykvJO7Kyg4XyQGVIMe6arpM9WNCDbsN698E3W9cpWuJhdmKgjZKF8gEfN5aQKfB5J2f0vEcvSp7w9rBTqupN/UvotR3M8CpdRZvopZ59FD/GPfsV41ZKugV4I9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Tw2sn5Xs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Tw2sn5Xs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95774C2BCAF; Mon, 13 Apr 2026 16:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776097766; bh=0wQEu5BE5XsDbsSV+RDaFyd0VeRYEt5s1+eiKKtrf74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tw2sn5XsZ6p31yTgNnkjsKTRsqNQCELUK3tCjdtDdunx/QUgNRl3cCQnlmaQEa6Rp 6Tfvnj8RdfnvxiRpCibP8F4VGw6jymdSPSwg8YdbxPyep5dMN5FFcQ/CpTnihqem/P hMB/YvkqzLh7+fzAAoz1tBF3N4mAdwnsdpWG7LOk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniel Hodges , Johannes Berg , Sasha Levin Subject: [PATCH 5.15 232/570] wifi: libertas: fix use-after-free in lbs_free_adapter() Date: Mon, 13 Apr 2026 17:56:03 +0200 Message-ID: <20260413155839.151942407@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155830.386096114@linuxfoundation.org> References: <20260413155830.386096114@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniel Hodges [ Upstream commit 03cc8f90d0537fcd4985c3319b4fafbf2e3fb1f0 ] The lbs_free_adapter() function uses timer_delete() (non-synchronous) for both command_timer and tx_lockup_timer before the structure is freed. This is incorrect because timer_delete() does not wait for any running timer callback to complete. If a timer callback is executing when lbs_free_adapter() is called, the callback will access freed memory since lbs_cfg_free() frees the containing structure immediately after lbs_free_adapter() returns. Both timer callbacks (lbs_cmd_timeout_handler and lbs_tx_lockup_handler) access priv->driver_lock, priv->cur_cmd, priv->dev, and other fields, which would all be use-after-free violations. Use timer_delete_sync() instead to ensure any running timer callback has completed before returning. This bug was introduced in commit 8f641d93c38a ("libertas: detect TX lockups and reset hardware") where del_timer() was used instead of del_timer_sync() in the cleanup path. The command_timer has had the same issue since the driver was first written. Fixes: 8f641d93c38a ("libertas: detect TX lockups and reset hardware") Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence") Cc: stable@vger.kernel.org Signed-off-by: Daniel Hodges Link: https://patch.msgid.link/20260206195356.15647-1-git@danielhodges.dev Signed-off-by: Johannes Berg [ del_timer() => timer_delete_sync() ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/marvell/libertas/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/wireless/marvell/libertas/main.c +++ b/drivers/net/wireless/marvell/libertas/main.c @@ -882,8 +882,8 @@ static void lbs_free_adapter(struct lbs_ { lbs_free_cmd_buffer(priv); kfifo_free(&priv->event_fifo); - del_timer(&priv->command_timer); - del_timer(&priv->tx_lockup_timer); + timer_delete_sync(&priv->command_timer); + timer_delete_sync(&priv->tx_lockup_timer); del_timer(&priv->auto_deepsleep_timer); }