From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BCDB17A31C; Mon, 20 Apr 2026 15:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700607; cv=none; b=uJqmgDeHBLMl6SnKnHrg5lJxSyYvXzOnvyxRc8Gglg3OENvGo1IsBmj1dKvdqjHYID7YIfc1TRMlnFF08CsfrvpNueYQkwm9u/cKL7mS8SPGpJXvFbtJovT630xNyVmn/2iVDdAN436GUb6LiprXY6W4wlvrkNPocXQrt0s8AS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700607; c=relaxed/simple; bh=DkQaVGV6/3o1WjjdI1c7RO2U752NPzdO4g5KB7UeIhE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tf9AJJydE+eIKCf4UfE7axXB2LuPixRn9isViRi14qdx+ncTAg4IcpGnDyWmepWv8Fe7n/Myh1cp765nAhm/7uCeeJ1CvaAM0UcP1+y4z9/9ylkRRPRo8ZXzhteByB55p6y4LbkvJRQladg8hl07qAJBqNJZiEFG5AGFm2osGak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UQIWwkhD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UQIWwkhD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4ECCC19425; Mon, 20 Apr 2026 15:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776700607; bh=DkQaVGV6/3o1WjjdI1c7RO2U752NPzdO4g5KB7UeIhE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UQIWwkhDVfWA2+SX3F2CSkOTG4e1hbmhOvoGH73xi1YfFwPBaBhuxMHkDHbx9Ixn+ VEGRok0xWdZgdel8r4wXvShhcYc7ofKQvpPD/B5/9Zt56C3l5V95p95UitjwxtjxX6 Lx6agSgjDFfLCJd+zSUOZRAMDWcaNJiDSZSuAmlw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Boris Burkov , Goldwyn Rodrigues , David Sterba , Sasha Levin Subject: [PATCH 6.18 018/198] btrfs: tracepoints: get correct superblock from dentry in event btrfs_sync_file() Date: Mon, 20 Apr 2026 17:39:57 +0200 Message-ID: <20260420153936.272688019@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420153935.605963767@linuxfoundation.org> References: <20260420153935.605963767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Goldwyn Rodrigues [ Upstream commit a85b46db143fda5869e7d8df8f258ccef5fa1719 ] If overlay is used on top of btrfs, dentry->d_sb translates to overlay's super block and fsid assignment will lead to a crash. Use file_inode(file)->i_sb to always get btrfs_sb. Reviewed-by: Boris Burkov Signed-off-by: Goldwyn Rodrigues Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- include/trace/events/btrfs.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h index 125bdc166bfed..0864700f76e0a 100644 --- a/include/trace/events/btrfs.h +++ b/include/trace/events/btrfs.h @@ -769,12 +769,15 @@ TRACE_EVENT(btrfs_sync_file, ), TP_fast_assign( - const struct dentry *dentry = file->f_path.dentry; - const struct inode *inode = d_inode(dentry); + struct dentry *dentry = file_dentry(file); + struct inode *inode = file_inode(file); + struct dentry *parent = dget_parent(dentry); + struct inode *parent_inode = d_inode(parent); - TP_fast_assign_fsid(btrfs_sb(file->f_path.dentry->d_sb)); + dput(parent); + TP_fast_assign_fsid(btrfs_sb(inode->i_sb)); __entry->ino = btrfs_ino(BTRFS_I(inode)); - __entry->parent = btrfs_ino(BTRFS_I(d_inode(dentry->d_parent))); + __entry->parent = btrfs_ino(BTRFS_I(parent_inode)); __entry->datasync = datasync; __entry->root_objectid = btrfs_root_id(BTRFS_I(inode)->root); ), -- 2.53.0