From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D8B2E093A; Mon, 20 Apr 2026 15:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700305; cv=none; b=pEgGdwV8F7odI44P/tQ7rDnxvkolBmoO7NQwnmJUbQjVRAm1Y/GszNBPOFaEvsmplOjKvEcPm0eQAEV1LZ4zRwRdIorEhACGgJu/++jVeYoKvE+ce68+j1QwK70Fp0+5MxHj6a8tb6jmb4YvBNI7ZcYMkfWKFT1QfQ6oZIuJKco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700305; c=relaxed/simple; bh=zWEqOrKGh7O9L+tHcG5AffAVPxrnXIV5wsWrTVo72Zw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c2P5OwNFVAOX2FFGEhaQByJbBO21EkMWvAPr45JtM9tDTaZvP1jvw+8UUXuYnqBlAobILHerJPIz833sIqqAiKENg3W2MkrzocGJvWIDKu2u1YMcR+6GnhGmyqdbKf/xVsgt1IFAXOwnoYO00s+cFQ7/9G9uyhDrjqNf1MJoGtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=M/ZT/Lbb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="M/ZT/Lbb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95495C19425; Mon, 20 Apr 2026 15:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776700304; bh=zWEqOrKGh7O9L+tHcG5AffAVPxrnXIV5wsWrTVo72Zw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M/ZT/Lbbs/txX/fEd8RiguuxVBSHDzdxiy65+dYXog9PW3aVV8Cf5ttAUrr74fZi7 5FVLlW5+57J4f3gjYSGwETnzzh/55v/uCrgzsQwKGewKTWxrDyhZw2ZOYD2Bwbrgv0 xGcRQnc1DTudAbRnTSUKbAS+3LIQibY5bUugM6GI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maciej Strozek , Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 6.19 121/220] ASoC: SDCA: Fix overwritten var within for loop Date: Mon, 20 Apr 2026 17:41:02 +0200 Message-ID: <20260420153938.385911849@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420153934.013228280@linuxfoundation.org> References: <20260420153934.013228280@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maciej Strozek [ Upstream commit 23e0cbe55736de222ed975863cf06baf29bee5fe ] mask variable should not be overwritten within the for loop or it will skip certain bits. Change to using BIT() macro. Fixes: b9ab3b618241 ("ASoC: SDCA: Add some initial IRQ handlers") Signed-off-by: Maciej Strozek Signed-off-by: Charles Keepax Link: https://patch.msgid.link/20260408093835.2881486-2-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/sdca/sdca_interrupts.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/sdca/sdca_interrupts.c b/sound/soc/sdca/sdca_interrupts.c index be269f204d623..4739fabb75f23 100644 --- a/sound/soc/sdca/sdca_interrupts.c +++ b/sound/soc/sdca/sdca_interrupts.c @@ -117,9 +117,7 @@ static irqreturn_t function_status_handler(int irq, void *data) status = val; for_each_set_bit(mask, &status, BITS_PER_BYTE) { - mask = 1 << mask; - - switch (mask) { + switch (BIT(mask)) { case SDCA_CTL_ENTITY_0_FUNCTION_NEEDS_INITIALIZATION: //FIXME: Add init writes break; -- 2.53.0