From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62511334C39; Mon, 20 Apr 2026 15:52:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700320; cv=none; b=PGG4SnszRuNH8IaN4tggMDqkdnLZTgJ/990DDQpN8JFt7H0xj6Vs/WDfUwVd3ZIWDMBwZohgzecthb1gvk5zUFFiWSy1HI8gmtsd1OlVZFJlNf8xSQrYfL40sDEyQmypj5VqeV2z1duM4ACq4EqgzGmlTXUQOV9PrwIGaNlv63o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700320; c=relaxed/simple; bh=j8VbCZ9HbnqpSGlcWAfqTpOCEA9XXksrdbjhrAnbl6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GEnm34K33iTFS2QJAh0F6Hxg9EKVZi/9qvFQYZ8ZaBNxG1yBwu9yrY6hiyRiiccaFpn07DTQJaHlRyOhaJm5s6RF6S+I4TrDeOMrZQUHZs17DAzzDLT49KoCLEZ2TqYuaiWHh5AhFRLRdoksdPc3vuhgLlsMP+8xO3ki5d/4SM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wAe5Xvss; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wAe5Xvss" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC194C19425; Mon, 20 Apr 2026 15:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776700320; bh=j8VbCZ9HbnqpSGlcWAfqTpOCEA9XXksrdbjhrAnbl6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wAe5Xvss3l91U8ZCo5T6f38nxqGULj8VfEClqdkowIttxOLJhcVtgkcHpfnE1vIh9 SAZLN8rI6f+Yy8FEMeQnpzjlFFfqnGEcWVxvUENl/mqXThnvw79VigIZcz3nTYQESb rKbQTULDWCqaFRV7/pi3fHOpAs55DPHy0hpEI0RQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fabio Baltieri , Jiawen Wu , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.19 126/220] net: txgbe: leave space for null terminators on property_entry Date: Mon, 20 Apr 2026 17:41:07 +0200 Message-ID: <20260420153938.564408546@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420153934.013228280@linuxfoundation.org> References: <20260420153934.013228280@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fabio Baltieri [ Upstream commit 5a37d228799b0ec2c277459c83c814a59d310bc3 ] Lists of struct property_entry are supposed to be terminated with an empty property, this driver currently seems to be allocating exactly the amount of entry used. Change the struct definition to leave an extra element for all property_entry. Fixes: c3e382ad6d15 ("net: txgbe: Add software nodes to support phylink") Signed-off-by: Fabio Baltieri Tested-by: Jiawen Wu Link: https://patch.msgid.link/20260405222013.5347-1-fabio.baltieri@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/wangxun/txgbe/txgbe_type.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h index 82433e9cb0e33..6b05f32b4a010 100644 --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h @@ -424,10 +424,10 @@ struct txgbe_nodes { char i2c_name[32]; char sfp_name[32]; char phylink_name[32]; - struct property_entry gpio_props[1]; - struct property_entry i2c_props[3]; - struct property_entry sfp_props[8]; - struct property_entry phylink_props[2]; + struct property_entry gpio_props[2]; + struct property_entry i2c_props[4]; + struct property_entry sfp_props[9]; + struct property_entry phylink_props[3]; struct software_node_ref_args i2c_ref[1]; struct software_node_ref_args gpio0_ref[1]; struct software_node_ref_args gpio1_ref[1]; -- 2.53.0