From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F58C3DE43B; Mon, 4 May 2026 14:07:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777903670; cv=none; b=E89sYvRoU6eu8B42dmLP8Niq2YtRKKwqRIzuiBBfyGaiqnYXtKKTTKgDUD9QFlDl3ocJy7cs76rJplpkTbpoOZiyWVdIaEX2Jf2xJ2IEVQ5wtbwEDHqGFusgd+1d+22p+iv5Tir+AtMBVeQAKsHV9PZ7u/c+SkCPQ/S4XlJpPgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777903670; c=relaxed/simple; bh=ouDT0Hf3mQ6A0e9fubqigM2J5uuPEL1VUCNRReZ+2x8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m8+LERIg/bBpCrJB/A94u5+152rB5sNoQvQuoGk/+bVVv6a6/DYxMWigqWpJQEXZH+uYOdBR+txzaIQgXpJUvoWL3JMRChWYqlQyTkSHfaJHw5uEgKyYkgQ2A4swLZJAvqCDQyzfUz4pbaT7aROvUa2o/pEnh97HkEN/w3v91qg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PpG2pbwW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PpG2pbwW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3F7AC2BCB8; Mon, 4 May 2026 14:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777903670; bh=ouDT0Hf3mQ6A0e9fubqigM2J5uuPEL1VUCNRReZ+2x8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PpG2pbwWAVCy+p3BRcwoZpKVU9V0A2JaGaQX/0j6ToOV2t20ewa+S/2J7w2C9ISsg EaSeGiuPYSpucl3jU7vhDILlcc213R8zm6Wj7wbrHCq18+hTnxGJ8/gNvA7bfuuQYM vkYe8ejdTOtzaW+re8UcQ3Mb++2b5+txfoZJVWss= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , Takashi Iwai Subject: [PATCH 6.18 003/275] ALSA: usb-audio: Fix Audio Advantage Micro II SPDIF switch Date: Mon, 4 May 2026 15:49:03 +0200 Message-ID: <20260504135143.061857861@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260504135142.929052779@linuxfoundation.org> References: <20260504135142.929052779@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cássio Gabriel commit a9224f26b754b5034719248891ff3c2ea0d11144 upstream. snd_microii_spdif_switch_put() returns 0 when the requested vendor register value differs from the cached one. This comparison was inverted by the resume-support conversion, so real SPDIF switch toggles are ignored while no-op writes still issue SET_CUR and report success. Return early only when the requested value matches the cached one. Fixes: 288673beae6c ("ALSA: usb-audio: Add resume support for MicroII SPDIF ctls") Cc: stable@vger.kernel.org Signed-off-by: Cássio Gabriel Link: https://patch.msgid.link/20260421-microii-spdif-switch-fix-v1-1-5c50dc28b88f@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/mixer_quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -2027,7 +2027,7 @@ static int snd_microii_spdif_switch_put( int err; reg = ucontrol->value.integer.value[0] ? 0x28 : 0x2a; - if (reg != list->kctl->private_value) + if (reg == list->kctl->private_value) return 0; kcontrol->private_value = reg;