From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC1A3D300A; Mon, 4 May 2026 14:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904051; cv=none; b=SV+lbL1Ub+TbCn+d+0s29ip/2m5MIpldyn5mscJkME43TXcpv/7D55aHQt9gJqz2ve0AJya0jI+bKfPxmaaPPw/6uqaiBsgwl64FkhLd2ReB3rOpJHGVAHq0rBak6T4fBzUsTF00GSFXasoz3z/eyTI5FmRRK/UkrEHJt+ojSYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904051; c=relaxed/simple; bh=se7XlK9K9klWw78kSPZmoes7h+mk3sX3/L9FRGSAo34=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BlhbYMZQXsfT74IvzyfVNZGX417mhFeAXmH7zd+4PUPjOqkTdyJ90TOjvVWhq2LIlF9fBph1/IY2EFFCmauJslZDqlICe2sZ9cC2IZAL8eOD97oka5v8mWOfIQWcfPRVWZLMIlLGT+S0CgjtxhdidfAQQKTessSnSUduOIAjHLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lzGCDdhM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lzGCDdhM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50B49C2BCB8; Mon, 4 May 2026 14:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777904051; bh=se7XlK9K9klWw78kSPZmoes7h+mk3sX3/L9FRGSAo34=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lzGCDdhMjsohSVsbWIaycmVRXMTxZxzG20PtKoQFBVGkbFYh8heT/ugiBtYIRSC6Y r0r4i7nGRYLKUPD0PBnjA9VPW7llmn2kqMrLO4h43tuCmwtPs+XNo5xcHgmjK45vmA g0MDI65RTNq9TequIkpo6odHeB9ZaZL4ri2QCVyQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Yuan Tan , Yifan Wu , Juefei Pu , Xin Liu , Ruijie Li , Ren Wei , Dust Li , Jakub Kicinski Subject: [PATCH 6.18 122/275] net/smc: avoid early lgr access in smc_clc_wait_msg Date: Mon, 4 May 2026 15:51:02 +0200 Message-ID: <20260504135147.438761301@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260504135142.929052779@linuxfoundation.org> References: <20260504135142.929052779@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ruijie Li commit 5a8db80f721deee8e916c2cfdee78decda02ce4f upstream. A CLC decline can be received while the handshake is still in an early stage, before the connection has been associated with a link group. The decline handling in smc_clc_wait_msg() updates link-group level sync state for first-contact declines, but that state only exists after link group setup has completed. Guard the link-group update accordingly and keep the per-socket peer diagnosis handling unchanged. This preserves the existing sync_err handling for established link-group contexts and avoids touching link-group state before it is available. Fixes: 0cfdd8f92cac ("smc: connection and link group creation") Cc: stable@kernel.org Reported-by: Yuan Tan Reported-by: Yifan Wu Reported-by: Juefei Pu Reported-by: Xin Liu Signed-off-by: Ruijie Li Signed-off-by: Ren Wei Reviewed-by: Dust Li Link: https://patch.msgid.link/08c68a5c817acf198cce63d22517e232e8d60718.1776850759.git.ruijieli51@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/smc/smc_clc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/smc/smc_clc.c +++ b/net/smc/smc_clc.c @@ -788,8 +788,8 @@ int smc_clc_wait_msg(struct smc_sock *sm dclc = (struct smc_clc_msg_decline *)clcm; reason_code = SMC_CLC_DECL_PEERDECL; smc->peer_diagnosis = ntohl(dclc->peer_diagnosis); - if (((struct smc_clc_msg_decline *)buf)->hdr.typev2 & - SMC_FIRST_CONTACT_MASK) { + if ((dclc->hdr.typev2 & SMC_FIRST_CONTACT_MASK) && + smc->conn.lgr) { smc->conn.lgr->sync_err = 1; smc_lgr_terminate_sched(smc->conn.lgr); }