From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D66B93EDE55; Tue, 12 May 2026 18:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778609043; cv=none; b=VLoq+1dZEvFGgFBfoBkVZORDMCyc63hix8xWlq7bxzUAZ+SbtaozM75agPgDkL8KjcjfwFPqE0j/87oQ+wMM1Yyk2TsMm61aA7oBg67aMRMWTKGug/oKu1wxZRbwVfZfySi+bgC8jMXNQFPkdC+AyEuq4QwmEM/V347qYcrs6Zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778609043; c=relaxed/simple; bh=bv1A5udFxk/IzUBe9oV/PzWZakYkCqZV9WTpT+GZx04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yyz9Tt0ron+TUsTgdxo0Mmk/ewqS2kWmWRkJVc15VsPe0Aeoqq9b+DPyThjeUXKIaaCKbZrt+zPSoq1BCEjwuspPwvxKkFdOnqDuzs+sLBoVqTAfWH9JTLOTa3FWlDVPZ/huRQ27kTjbRlX3PAHCZG+AMc21JpaUf0RUhkFzkyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jmQy+wR+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jmQy+wR+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D02DC2BCB0; Tue, 12 May 2026 18:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778609043; bh=bv1A5udFxk/IzUBe9oV/PzWZakYkCqZV9WTpT+GZx04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jmQy+wR+akwCuOyTup4ifCu3o3Yd9tQggrc4yRZqHqOrlVXWBZFSWJMJcKMycJn7a ScLbrQGNhQ0ZHgBrxrkW40/hziiHWkhJW2Q09d8FH80a2nhWZrLb9Pxa9IMXElScuS +3CVwTIotoy47ggy8Tq5+x0E6qMxlmLloJ9o7Oaw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Felix Gu , Heikki Krogerus Subject: [PATCH 7.0 043/307] usb: ulpi: fix memory leak on ulpi_register() error paths Date: Tue, 12 May 2026 19:37:18 +0200 Message-ID: <20260512173941.033676320@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512173940.117428952@linuxfoundation.org> References: <20260512173940.117428952@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Gu commit 0b9fcab1b8608d429e5f239afb197de928d4de7d upstream. Commit 01af542392b5 ("usb: ulpi: fix double free in ulpi_register_interface() error path") removed kfree(ulpi) from ulpi_register_interface() to fix a double-free when device_register() fails. But when ulpi_of_register() or ulpi_read_id() fail before device_register() is called, the ulpi allocation is leaked. Add kfree(ulpi) on both error paths to properly clean up the allocation. Fixes: 01af542392b5 ("usb: ulpi: fix double free in ulpi_register_interface() error path") Cc: stable Signed-off-by: Felix Gu Reviewed-by: Heikki Krogerus Link: https://patch.msgid.link/20260407-ulpi-v1-1-f3fafe53f7b2@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/common/ulpi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -286,12 +286,15 @@ static int ulpi_register(struct device * ACPI_COMPANION_SET(&ulpi->dev, ACPI_COMPANION(dev)); ret = ulpi_of_register(ulpi); - if (ret) + if (ret) { + kfree(ulpi); return ret; + } ret = ulpi_read_id(ulpi); if (ret) { of_node_put(ulpi->dev.of_node); + kfree(ulpi); return ret; }