From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB373EDE49; Tue, 12 May 2026 17:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608734; cv=none; b=F8Ko1ggfW9SdgcX6aldI/LzgffCuChLSOjJoR+jQqmFahMn545GYOIl60//eYO2AuXmheOwJOYEOJsb6NPlg3Dbq6S+Ac7YvAEheeJGPeGIMCgn6Lo2YzIWrnUf/Fh9n1KVRsFh/7wVraHZ32KisXI+LqIG7BD8BrA8vhjGSuPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608734; c=relaxed/simple; bh=WlcT09aDDgIqhfEyUc3dIEeXiEIWx4hQ8C6b0SuLNCo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hhgVAMfxCmhZ8S+1UDSaBWvnigObGv5mExmtJdABeuKnRoo1IH/9dUSaqyyyxcIfJcsdLHDKiDOs0R9CcF7pZMoV0NLMBJ3B8hyzs/ye+XFyKNxbUgtBQwQLQMqf5659McPFxYTAZQh+mff1yu6snd0SUv0ynrdkNfGfD1P8IXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NBgzv4W0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NBgzv4W0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17918C2BCB0; Tue, 12 May 2026 17:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778608734; bh=WlcT09aDDgIqhfEyUc3dIEeXiEIWx4hQ8C6b0SuLNCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NBgzv4W023L4tiWyFHd/2IQ8vvHcF01U2vzSxPMSsuyfQ88aTiyyDyxhH7gib1ePg G/VX3cCmfGUH8H//v20ZgrN6ytNlmszQqoMSBjjYfg1xwngicX3Tkpa4nUaiYtVhuJ 8ZF26/K/APXPbGgZqatDlj/2lfQ7T6PgkuuTwwig= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Long Li , Jason Gunthorpe Subject: [PATCH 6.18 194/270] RDMA/mana: Fix error unwind in mana_ib_create_qp_rss() Date: Tue, 12 May 2026 19:39:55 +0200 Message-ID: <20260512173942.533560535@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512173938.452574370@linuxfoundation.org> References: <20260512173938.452574370@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jason Gunthorpe commit 6aaa978c6b6218cfac15fe1dab17c76fe229ce3f upstream. Sashiko points out that mana_ib_cfg_vport_steering() is leaked, the normal destroy path cleans it up. Cc: stable@vger.kernel.org Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter") Link: https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4 Link: https://patch.msgid.link/r/7-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com Reviewed-by: Long Li Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mana/qp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/infiniband/hw/mana/qp.c +++ b/drivers/infiniband/hw/mana/qp.c @@ -236,13 +236,15 @@ static int mana_ib_create_qp_rss(struct ibdev_dbg(&mdev->ib_dev, "Failed to copy to udata create rss-qp, %d\n", ret); - goto fail; + goto err_disable_vport_rx; } kfree(mana_ind_table); return 0; +err_disable_vport_rx: + mana_disable_vport_rx(mpc); fail: while (i-- > 0) { ibwq = ind_tbl->ind_tbl[i];