From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEC0933B6CC; Tue, 12 May 2026 18:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778609689; cv=none; b=QWHceqsM0RbCo+PSyOx8SGMHKL5fYfCujxfMH8gWWxQVDA1hQVKJ3Xqcx4bdSeVWPbUPF9GVhRMJR9YuTClIKxyQSkhjkKoylvzsVHhXsudlP6nPWFEpuRYTt/CL45dFcp/I11jUQENIKs7ImAG6QT7bL9+1/f7+8Oz5/Xwo86M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778609689; c=relaxed/simple; bh=Yy5Bo+tRlnD6YAe+cHUo31tkGdGdQBAUVFV6acA6A4U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R28Pl3qj+FIpLGnxnZO2w1RVAle59BV/mw8vdJW4/Ml0+8g39sV3tvTkvmKMxSAVZ1dV/6IVXNpMnydF+BX4nFcF0xi/Ln0qommML0ukPB3+l8Z1xXg+Z5XgfHlToAarRx8NTLyJI8zYmzbU4i0TepVNHJ0Rr8p1nXKoU1bFfdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eyd0OypS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eyd0OypS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66797C2BCF6; Tue, 12 May 2026 18:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778609689; bh=Yy5Bo+tRlnD6YAe+cHUo31tkGdGdQBAUVFV6acA6A4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eyd0OypSLH7z3q4KfwyFRk0nDsg0tEcyYArDV37iHuKE71A7lzVmhQgczjGMH0IHv GYPTR2nVj/Kk25zwnFaiPLcuWUiLDp5mqTHFik9sZU+yyqXvN/Z8Vs+c/cQ8RM7va0 TEcZojR7Gh9XJq6cuqxeS8gwSjaOJxgQFfQKORHw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Matthieu Baerts (NGI0)" , Shardul Bankar , Jakub Kicinski Subject: [PATCH 7.0 252/307] mptcp: use MPJoinSynAckHMacFailure for SynAck HMAC failure Date: Tue, 12 May 2026 19:40:47 +0200 Message-ID: <20260512173945.445085114@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512173940.117428952@linuxfoundation.org> References: <20260512173940.117428952@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shardul Bankar commit c4a99a921949cddc590b22bb14eeb23dffcc3ba6 upstream. In subflow_finish_connect(), HMAC validation of the server's HMAC in SYN/ACK + MP_JOIN increments MPTCP_MIB_JOINACKMAC ("HMAC was wrong on ACK + MP_JOIN") on failure. The function processes the SYN/ACK, not the ACK; the matching MPTCP_MIB_JOINSYNACKMAC counter ("HMAC was wrong on SYN/ACK + MP_JOIN") exists but is not incremented anywhere in the tree. The mirror site on the server, subflow_syn_recv_sock(), already uses JOINACKMAC correctly for ACK HMAC failure. Use JOINSYNACKMAC at the SYN/ACK validation site so each counter reflects the packet whose HMAC actually failed. Suggested-by: Matthieu Baerts (NGI0) Fixes: fc518953bc9c ("mptcp: add and use MIB counter infrastructure") Cc: stable@vger.kernel.org Signed-off-by: Shardul Bankar Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) Link: https://patch.msgid.link/20260501-net-mptcp-misc-fixes-7-1-rc3-v1-1-b70118df778e@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -581,7 +581,7 @@ static void subflow_finish_connect(struc subflow->backup); if (!subflow_thmac_valid(subflow)) { - MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_JOINACKMAC); + MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_JOINSYNACKMAC); subflow->reset_reason = MPTCP_RST_EMPTCP; goto do_reset; }