From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06AB13CF67B; Fri, 15 May 2026 16:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778862116; cv=none; b=LD4iP5wHWKAl3DUUY+MnS65bniFOhkjxwHgeGX6keLmcxR5swqdlXtInEIcAiBdvk97NXclLekRTHzUnunt7hs05TuzdNGfAd6yWZfMY0hx9QUdmksRametWEFGd0BDDhY5jdzs+Cy2UuivjMINpoLLjKrnL/dNbisG4e+bO6Yw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778862116; c=relaxed/simple; bh=7MsG61iorMdVb/bviZIZwkwjm3liE8gGtrxnt2nHlsc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mqd6zjhS5IZg4C+R2sHFBJ7Rj1+QEfsmmOOBj18USNZE/UtG4W0bYKmBg55fSdDwR1vEQlVLt89MiJkkcf7pySqon7+YcJNN0gI1zQQgNRp/gE1cMYP8Ls9LlRJI9cRc4x2hHL+maWx9zniTfPgnzLcG2YO3FqgV1gHnCQcx7X0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=if+u0Vi6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="if+u0Vi6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86834C2BCB0; Fri, 15 May 2026 16:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778862115; bh=7MsG61iorMdVb/bviZIZwkwjm3liE8gGtrxnt2nHlsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=if+u0Vi6klFFCTGD5QNBnZNSiYIrn/IK3jPpQ12tVq/WaEoxaAWbaX1Fe/0dO9NOc GoUuDCovFuu0+t+BFiwCGmQ1hBMbOz4kg0POLV0MPCzxOehr8QVbEFilWIgqFRbybF tG7o1VQkh/Vz8fyjIq7K4IphwJJdeBWOAhu+vG9M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jingoo Han , Johan Hovold , Mark Brown Subject: [PATCH 6.18 063/188] spi: mxs: fix controller deregistration Date: Fri, 15 May 2026 17:48:00 +0200 Message-ID: <20260515154658.682601887@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154657.309489048@linuxfoundation.org> References: <20260515154657.309489048@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 8b0d0011af20fb547aa67a1cefbf320992fd5e92 upstream. Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 33e195acf268 ("spi: mxs: use devm_spi_register_master()") Cc: stable@vger.kernel.org # 3.13 Cc: Jingoo Han Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-4-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-mxs.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -619,7 +619,7 @@ static int mxs_spi_probe(struct platform if (ret) goto out_pm_runtime_put; - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&pdev->dev, "Cannot register SPI host, %d\n", ret); goto out_pm_runtime_put; @@ -650,11 +650,17 @@ static void mxs_spi_remove(struct platfo spi = spi_controller_get_devdata(host); ssp = &spi->ssp; + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) mxs_spi_runtime_suspend(&pdev->dev); dma_release_channel(ssp->dmach); + + spi_controller_put(host); } static struct platform_driver mxs_spi_driver = {