From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833603F9282; Fri, 15 May 2026 16:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778862064; cv=none; b=olaSXc97gACwsCxFMctLvtNyzCQ/aBiWNyA+y6XcE2yW1mxsMwda2Pl18Xg54gpPUz/80Xw8ZXQ17Yf3BsBBL/voLTdJNNSiCTwP5TZmxJHhN2bWmWXfaQJb6mWygtx6Dj+y1XSiwqKvy93MKDOu8N6BsVyECLzMccBzuUQQcj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778862064; c=relaxed/simple; bh=zt3fPTZ9hB1F92ssbx244e0qnjpouLQOiaAx7LFWPtY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z7rayMYkOFCoICMXMlP/KaH3Cngs+PqZApynMqt64oeLTpvJ7wscy/mG8OLxLhD+qq7Y8FBnrk2VuM2r8qaJ2Gzc3GgN8SfE1uGmP4OFawaa2aGrGS1VmEkVlnfwrVS/uuUiGWxdKGCBq+8euCH78EUkhndXDGyWEL32TliiNbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lt3BeXO+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lt3BeXO+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A3FDC2BCB0; Fri, 15 May 2026 16:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778862064; bh=zt3fPTZ9hB1F92ssbx244e0qnjpouLQOiaAx7LFWPtY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lt3BeXO+CnOX9VkF5M47ygawf+lheYTBWAcUZWWpKPC0NF6c78u7JfPtYQTOfdZ0e 95vW6OT2pfexQ7PrltFxl5Zh9Bt2cPoef1O8d7rjcM8LbBmxpAK+/eXCdwDTYTTaYn ebFtLNyQsI5LxYhN7cixA+Fe5YIgyTNgxXhIn4e0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pei Xiao , Johan Hovold , Mark Brown Subject: [PATCH 6.18 093/188] spi: mpc52xx: fix use-after-free on unbind Date: Fri, 15 May 2026 17:48:30 +0200 Message-ID: <20260515154659.346317102@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154657.309489048@linuxfoundation.org> References: <20260515154657.309489048@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 706b3dc2ac7a998c55e14b3fd2e8f934c367e6e0 upstream. The state machine work is scheduled by the interrupt handler and therefore needs to be cancelled after disabling interrupts to avoid a potential use-after-free. Fixes: 984836621aad ("spi: mpc52xx: Add cancel_work_sync before module remove") Cc: stable@vger.kernel.org Cc: Pei Xiao Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260414134319.978196-5-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-mpc52xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-mpc52xx.c +++ b/drivers/spi/spi-mpc52xx.c @@ -525,10 +525,11 @@ static void mpc52xx_spi_remove(struct pl spi_unregister_controller(host); - cancel_work_sync(&ms->work); free_irq(ms->irq0, ms); free_irq(ms->irq1, ms); + cancel_work_sync(&ms->work); + for (i = 0; i < ms->gpio_cs_count; i++) gpiod_put(ms->gpio_cs[i]);