From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71DD2305674; Fri, 15 May 2026 15:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778860647; cv=none; b=NFlyWp71YAF8ZE6XOqU/ZWagCXtBxflWJ628vmDSOYtj5HFhtGMcckuMpSH9H5vHBCslUP15F6MEF5w6aDATiygdqqs5UPUHkoQby4qc0iOAT0akHkSeY8jSblTh4VeVtu4Uu/Ln7+GUD4DmjIqwhY3Om/cC3BfLBd9UBj2kpUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778860647; c=relaxed/simple; bh=lv+DmsJc7qRSTtc6bN5DicfWQU9HRIfsh84pqDtk5jU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uQ95ScpaSUl5sL4d3rhNArU7NWIoys2W0O25D//xitGuZQsTPAKPbyNAjYHSUwDGs2p1Xlb8sFxJP9iXqigL13KsY3kEXYUDai9RPeLQUPwyHVBTj7+TYnZMqA58RqSL0Q6eA955omjeoTmi1nXxLSzKZ57J7yTE/Z0mx3fQZCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=M/zMkXIT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="M/zMkXIT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07FA9C2BCB0; Fri, 15 May 2026 15:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778860647; bh=lv+DmsJc7qRSTtc6bN5DicfWQU9HRIfsh84pqDtk5jU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M/zMkXITVASV/VU1bl6vxkU6qUAzFxCsnPGkEzlc3jmRoOiq74YvjrwnRwYoc1j/m bfW5Yc9KVISTQKRVJ8YmHN+n1hMd4BZPp7BDtr9g2FPvCMpfiZdtvBcBE6s2S1QWzS wXg+jM1DEm7G/x2UoXpzkgORAg/GKneTEbIh2lpQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , stable Subject: [PATCH 6.6 008/474] drm/nouveau: fix u32 overflow in pushbuf reloc bounds check Date: Fri, 15 May 2026 17:41:57 +0200 Message-ID: <20260515154715.236478438@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 2fc87d37be1b730a149b035f9375fdb8cc5333a5 upstream. nouveau_gem_pushbuf_reloc_apply() validates each relocation with if (r->reloc_bo_offset + 4 > nvbo->bo.base.size) but reloc_bo_offset is __u32 (uapi/drm/nouveau_drm.h) and the integer literal 4 promotes to unsigned int, so the addition is performed in 32 bits and wraps before the comparison against the size_t bo size. Cast to u64 so the addition happens in 64-bit arithmetic. Cc: Lyude Paul Cc: Danilo Krummrich Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Reported-by: Anthropic Cc: stable Assisted-by: gkh_clanker_t1000 Fixes: a1606a9596e5 ("drm/nouveau: new gem pushbuf interface, bump to 0.0.16") Signed-off-by: Greg Kroah-Hartman [ Add Fixes: tag. - Danilo ] Signed-off-by: Danilo Krummrich Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -679,7 +679,7 @@ nouveau_gem_pushbuf_reloc_apply(struct n } nvbo = (void *)(unsigned long)bo[r->reloc_bo_index].user_priv; - if (unlikely(r->reloc_bo_offset + 4 > + if (unlikely((u64)r->reloc_bo_offset + 4 > nvbo->bo.base.size)) { NV_PRINTK(err, cli, "reloc outside of bo\n"); ret = -EINVAL;