From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899742EAB82; Fri, 15 May 2026 16:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861070; cv=none; b=pWoDsBFQAjwizsa36Rou2uFvxhz8QoGicSX4rMa9rjydfW2DYsRYnpEcI/qWYo5ysU/JI84K7rur/Ui8czHutJDqM1SRSDVUPLsRXZiaShFKYCnkldAeZZB3rufU1uSC0swDtoB0qQBw7CRSXGegpmWS5vYcclC/FeepfO2cb4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861070; c=relaxed/simple; bh=wL/exdIolgbx7TJ5Ky6axLIEo5Q11GMry3njxsYiLss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DE5RqUE7ZHogdmitYgb70QaO6RJxUt2vglZt6jWFdMdGZI3bIiNBYbTOJvixgbfWXPvFiBgewEY2XivVO5cvltXPpCVDGZnSkgNwFK/8OANtdFAceBmXwNsBcm6v7gL18E80FphWL0yEYwHUnmE1vfhRElNRIoVLWXm5oapr8DQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lG8dO9au; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lG8dO9au" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F911C2BCB0; Fri, 15 May 2026 16:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861070; bh=wL/exdIolgbx7TJ5Ky6axLIEo5Q11GMry3njxsYiLss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lG8dO9auZxI3zweYKrfa25FDG28wTXbwAjn5nFhEDQiTb29pV5ZMgaMkWNXSnPPld GW1d+aETgPYZEz7NlQcTWoOs28yQkXRPKpH6FzqvOx7vnZQwnLXKUkHQ78UnHkMEPR X1lkBWe1oVKdR4vEdkay7e8hqkN1LGdDldQvzYCs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tristan Madani , Johannes Berg Subject: [PATCH 6.6 186/474] wifi: b43legacy: enforce bounds check on firmware key index in RX path Date: Fri, 15 May 2026 17:44:55 +0200 Message-ID: <20260515154719.047661168@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tristan Madani commit a035766f970bde2d4298346a31a80685be5c0205 upstream. Same fix as b43: the firmware-controlled key index in b43legacy_rx() can exceed dev->max_nr_keys. The existing B43legacy_WARN_ON is non-enforcing in production builds, allowing an out-of-bounds read of dev->key[]. Make the check enforcing by dropping the frame for invalid indices. Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani Link: https://patch.msgid.link/20260417111145.2694196-2-tristmd@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/broadcom/b43legacy/xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/wireless/broadcom/b43legacy/xmit.c +++ b/drivers/net/wireless/broadcom/b43legacy/xmit.c @@ -476,7 +476,8 @@ void b43legacy_rx(struct b43legacy_wldev * key index, but the ucode passed it slightly different. */ keyidx = b43legacy_kidx_to_raw(dev, keyidx); - B43legacy_WARN_ON(keyidx >= dev->max_nr_keys); + if (B43legacy_WARN_ON(keyidx >= dev->max_nr_keys)) + goto drop; if (dev->key[keyidx].algorithm != B43legacy_SEC_ALGO_NONE) { /* Remove PROTECTED flag to mark it as decrypted. */