From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617773FE36A; Wed, 20 May 2026 18:50:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779303060; cv=none; b=aKtNSNzQDNbFsIjLkm8QOz10T+c59SlvNoZL0fk1vvCx7Z2KruBvS2BZTHFjysH5qW5vbXg7l5wgfnJFGpaAt9sdZfrF50Igb7L6RWfKIuV8/gE3VAlN4WCm7/Dz/rkLvgk8fBDgH928cfa7WZWn+frQViz+lqEjRSSav+ypE4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779303060; c=relaxed/simple; bh=0NDYSYkyJueR4pvW1LZW6aLe0h6Qfa76QjvA+YzyAGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CyomsL6mrHPApWskoY6r3FB8r/zzIwaW0DGzRhZCy52KGAyC93jIAg4JrkRbDcqDselJvOiD09D4qiH4s2J4vJtlMb0TmCP8hGvdIK+oCwBSQoWCNFWZOkXRFeXDZTK/bGPntU3E2MrQWMwZxE3KLauxeKHE67BcCMxx8jmpIRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=A2eiVKgF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="A2eiVKgF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC2591F00893; Wed, 20 May 2026 18:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779303059; bh=/rbP+9j2mns1a6pVhj8nyIhd7ddK+v3KRIeVKBn7fTE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=A2eiVKgFfe7luoVjNXJkPcKB56HM61iWaXh44Y9B/OR5LFV+GfLNEHK0SJaWHf219 NURsWkjNlKWz054w/DtOZpIUO0g0+N1z0rscYKOfZdTJ7W5KCx/W4m09zSysT/S3/j AHynl1mwkCO0ivkmxZVl3sivLKwPlbI+K0g7Z1EI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lee Jones , Johan Hovold , Mark Brown , Sasha Levin Subject: [PATCH 6.6 503/508] spi: st-ssc4: fix controller deregistration Date: Wed, 20 May 2026 18:25:26 +0200 Message-ID: <20260520162109.499774318@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162058.573354582@linuxfoundation.org> References: <20260520162058.573354582@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit 19857374010d06ca6a2f7c2c53464122eb804df0 ] Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: 9e862375c542 ("spi: Add new driver for STMicroelectronics' SPI Controller") Cc: stable@vger.kernel.org # 4.0 Cc: Lee Jones Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-18-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-st-ssc4.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-st-ssc4.c +++ b/drivers/spi/spi-st-ssc4.c @@ -349,7 +349,7 @@ static int spi_st_probe(struct platform_ platform_set_drvdata(pdev, host); - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&pdev->dev, "Failed to register host\n"); goto rpm_disable; @@ -371,10 +371,16 @@ static void spi_st_remove(struct platfor struct spi_controller *host = platform_get_drvdata(pdev); struct spi_st *spi_st = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(&pdev->dev); clk_disable_unprepare(spi_st->clk); + spi_controller_put(host); + pinctrl_pm_select_sleep_state(&pdev->dev); }