From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B703370D54; Wed, 20 May 2026 18:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779300099; cv=none; b=f0UuSVrYKSol9FhtHwkDeYDEN/j7W5q4Bu8CWZku0WcMRrdDN7gk4KzBkBlzrg6VPOX7aRn9cBJRs/1whXDpXupCauTG65ioW60gJMycaEu97v9H3WhKMJf8II9xc7RWdL2YB+HlgL2Jfvb4BWnU0OOKEAK8f7XeKSwp3zEAd90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779300099; c=relaxed/simple; bh=rbzqTV2OUoyweVcqSPcAVweRjBx6JfIO+lAgg8Hwbkc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OCusZwcEdC0nBYTsWZYlXmOiTKgPl5M/oB8+KcIZeF/Cn/xZuz0TU8jiIo6KB4kfG5LQ8bgWdvOYcnG+3B2yHXgwayIYFsihc0dR8EFnzdJnANFiuI1wfa5DhN5gMv/JkBcn85vC0LrMa0Lr5mVAS5L/sj1hLdxp6KpWwgBORh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zs9Kn/Vs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zs9Kn/Vs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A14CF1F000E9; Wed, 20 May 2026 18:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779300098; bh=cTpMtFOpl+X2jHjqCVZ6e0o7vvz/Fy1G2Xasz+eSI30=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zs9Kn/VsB6Gv6ohc7StYJwVVGRjkh0cXRgYob/786DQqQfixT0Q9MBEP9tYHc+vrI w2YUrboJ8ld/RL7I6zzOXDmYLP6/93vQ7TRi0Zq0LBBgEFKFk6wgue/1NBSs/rybqA Fmbje4On9OQDsZJNjQzIGSD5u9q82qd/RhY4NgSo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ming Yen Hsieh , Felix Fietkau , Sasha Levin Subject: [PATCH 6.12 047/666] wifi: mt76: mt7925: prevent NULL vif dereference in mt7925_mac_write_txwi Date: Wed, 20 May 2026 18:14:18 +0200 Message-ID: <20260520162112.259821368@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162111.222830634@linuxfoundation.org> References: <20260520162111.222830634@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ming Yen Hsieh [ Upstream commit 962eb04e67552be406c906c83099c1d736aae3b6 ] Check for a NULL `vif` before accessing `ieee80211_vif_is_mld(vif)` to avoid a potential kernel panic in scenarios where `vif` might not be initialized. Fixes: ebb1406813c6 ("wifi: mt76: mt7925: add link handling to txwi") Signed-off-by: Ming Yen Hsieh Link: https://patch.msgid.link/20250904030649.655436-3-mingyen.hsieh@mediatek.com Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt7925/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c index e308c97b574b8..e5de05a91aee7 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c @@ -807,8 +807,8 @@ mt7925_mac_write_txwi(struct mt76_dev *dev, __le32 *txwi, txwi[5] = cpu_to_le32(val); val = MT_TXD6_DAS | FIELD_PREP(MT_TXD6_MSDU_CNT, 1); - if (!ieee80211_vif_is_mld(vif) || - (q_idx >= MT_LMAC_ALTX0 && q_idx <= MT_LMAC_BCN0)) + if (vif && (!ieee80211_vif_is_mld(vif) || + (q_idx >= MT_LMAC_ALTX0 && q_idx <= MT_LMAC_BCN0))) val |= MT_TXD6_DIS_MAT; txwi[6] = cpu_to_le32(val); txwi[7] = 0; -- 2.53.0