From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FE74348C55; Wed, 20 May 2026 18:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301300; cv=none; b=J9/c+T/jhKlw3z8EyAWIhgf75uDQZQb+yuE72g0ZUfv18YE0piNQ/tDR0eLDz2Hy1uKlR0JbVPC/GUuBGFVAuCwKhVWbWl7vwGadtEm4MuhMopZFO3jnoMbMuTtj5yH7R/XZstVEF2ZE23uDVgklrAYBg25qDTw/jGRMxAY4v9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301300; c=relaxed/simple; bh=YoZLGIK097EQcXMZ8EgU1elDZ91r4oaOcEQUbbFcAQc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mj7wLXIgoB/HQwSPn6uhjjJczigy5dhJ6Rofl1/DdoDsti3FGwEDUJZ3XMZaNA1fHcN1n56vh9OHey3jmuWoYJNeQ+bgvwnsLk/0vV6dOKj8W4GDuQPrRtEc8jSr9CzomRsEbqq2PMl29qfRb6P9Cw8K9vB/+2jogoARmJKa+24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d+ZXv26e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d+ZXv26e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BDFA1F000E9; Wed, 20 May 2026 18:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779301299; bh=ugwvkhVjtWVuucHOWS7bTpmXkY9udt442M5D2gZ3NrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=d+ZXv26e/2gayjB5snbh39ujwnNAACP0+7n7MnhvhO7LUWngaDpt6KSpWFtHgYV9F H7qeuRyXZV7WCleqMhUKq3KgrJg7H96V10uY9w+C1Jk3cO6qChc/Wf96C9z5vVO3Fs Xn2S8oZt78ITvaK/kej1TVPAhk83StSFBYeyGcW0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Myeonghun Pak , Ijae Kim , Taegyu Kim , Yuho Choi , Helge Deller , Sasha Levin Subject: [PATCH 6.12 502/666] fbdev: offb: fix PCI device reference leak on probe failure Date: Wed, 20 May 2026 18:21:53 +0200 Message-ID: <20260520162122.141270129@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162111.222830634@linuxfoundation.org> References: <20260520162111.222830634@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuho Choi [ Upstream commit 869b93ba04088713596e68453c1146f52f713290 ] offb_init_nodriver() gets a referenced PCI device with pci_get_device(). If pci_enable_device() fails, the function returns without dropping that reference. Release the PCI device reference before returning from the pci_enable_device() failure path. Fixes: 5bda8f7b5468 ("video: fbdev: offb: Call pci_enable_device() before using the PCI VGA device") Co-developed-by: Myeonghun Pak Signed-off-by: Myeonghun Pak Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Co-developed-by: Taegyu Kim Signed-off-by: Taegyu Kim Signed-off-by: Yuho Choi Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/offb.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c index f85428e13996b..166b2dff36f59 100644 --- a/drivers/video/fbdev/offb.c +++ b/drivers/video/fbdev/offb.c @@ -640,8 +640,13 @@ static void offb_init_nodriver(struct platform_device *parent, struct device_nod vid = be32_to_cpup(vidp); did = be32_to_cpup(didp); pdev = pci_get_device(vid, did, NULL); - if (!pdev || pci_enable_device(pdev)) + if (!pdev) return; + + if (pci_enable_device(pdev)) { + pci_dev_put(pdev); + return; + } } #endif /* kludge for valkyrie */ -- 2.53.0