From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D229C3FBEC0; Wed, 20 May 2026 18:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301490; cv=none; b=FfP3D70/7tCIfQDOXuAhS7nFaGka/qj81EZsaVCRstcrJGjB6QepURJssxS1zLN8KpkLdNSm+8+ivKlLak2+z2zAUgh+7wg+N5eGqBHjprIfov65K4FJl+7mmn37MXI7N/EwaGqG11s/qeUpyrAem8IZliZ9X93ubHEvak4z4q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301490; c=relaxed/simple; bh=3yaw0rZ8ifltM7CgkTI2Spx241Udp6b/HgDWsOsw5Cg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kkx/sFwCSAiJfeSCrVYs0MP93TZFpoCk476xgF97bn4yeTzKozwGFxjz/v7W78k8hUwoANl/iG5wd7/nSU1/P0B2+pEhSVcyYT9v5V+EDciNi/vffOUk1DWuCsRa4q6jKLO4j604X8QiBWEH1ZQFcCKF+R1L0KrAmGLY0apXXBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bdTAJ+Na; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bdTAJ+Na" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42EE31F00893; Wed, 20 May 2026 18:24:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779301488; bh=x76T29Fd26tZ0/0cJyAFjC3gWYqavbYyvxYXHFL0muA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bdTAJ+NaIzBZwe+2eVDRXWH2v1tWcYXZ9pZkP/H0cfJP6gCP6hR1T1rZvOfC4r8QC 7G9WJUcL93hgzsB1RdNAmKo3BFWSocR/dMg5anoFrUC+u1INDZhg2CfK09mPmi62gX ZaieDXz3vyJQBHZ9az9yC0l5MGUeaS82zWJWe6fQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, wangdicheng , Takashi Iwai , Sasha Levin Subject: [PATCH 6.12 575/666] ALSA: hda/conexant: Fix missing error check for jack detection Date: Wed, 20 May 2026 18:23:06 +0200 Message-ID: <20260520162123.729134838@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162111.222830634@linuxfoundation.org> References: <20260520162111.222830634@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: wangdicheng [ Upstream commit b0e2333a231107adedd38c6fcfe1adc6162716fc ] In cx_probe(), the return value of snd_hda_jack_detect_enable_callback() is ignored. This function returns a pointer, and if it fails (e.g., due to memory allocation failure), it returns an error pointer which must be checked using IS_ERR(). If the registration fails, the driver continues to probe, but the jack detection callback will not be registered. This can lead to a kernel crash later when the driver attempts to handle jack events or accesses the uninitialized structure. Check the return value using IS_ERR() and propagate the error via PTR_ERR() to the probe caller. Fixes: 7aeb25908648 ("ALSA: hda/conexant: Fix headset auto detect fail in cx8070 and SN6140") Signed-off-by: wangdicheng Link: https://patch.msgid.link/20260428080450.108801-1-wangdich9700@163.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/patch_conexant.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 00ac0e170619b..0296777bb380b 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -1182,6 +1182,7 @@ static void add_cx5051_fake_mutes(struct hda_codec *codec) static int patch_conexant_auto(struct hda_codec *codec) { struct conexant_spec *spec; + struct hda_jack_callback *callback; int err; codec_info(codec, "%s: BIOS auto-probing.\n", codec->core.chip_name); @@ -1198,7 +1199,12 @@ static int patch_conexant_auto(struct hda_codec *codec) case 0x14f11f86: case 0x14f11f87: spec->is_cx11880_sn6140 = true; - snd_hda_jack_detect_enable_callback(codec, 0x19, cx_update_headset_mic_vref); + callback = snd_hda_jack_detect_enable_callback(codec, 0x19, + cx_update_headset_mic_vref); + if (IS_ERR(callback)) { + err = PTR_ERR(callback); + goto error; + } break; } -- 2.53.0