From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B30033BBAF; Wed, 20 May 2026 17:16:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297416; cv=none; b=X2nl1oyhKFbc6DIqgEASOA3TcIfC337ufX4otmB/C1I28wD9wGUkpSHa4zTQgOymYhzwAYaYnXDXfI0St/3IONUTDucpP3bQfc3s2dhSaWGbTwloYZf7A8CVSSQiEjNKGdoShbaHqFke0bnFBtU0xXZdee6dkMiuJFNICReNFfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297416; c=relaxed/simple; bh=eAJZq5kxVSirTYPvLk0yvRFIcIjMwo6GLznjJmrU31E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LgUa7mVeycHRyDdcYUKEIjf4t5H0unUkhTNXjXRD8BRaqr5MvevhUNYWm4OUOLok4WMfZ3BLM9MwH9/5RboUEmlqRnQ4iJBlTKpB/Np01kAcSELhDUDSd4eOpUcVj9qOEGhp9vd8bCpzVeCweDMLOtY+EBhR2Hp+9QT+JL/IJx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=01SyFk+m; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="01SyFk+m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF28F1F000E9; Wed, 20 May 2026 17:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779297415; bh=ku4pi0ZbVyek84rRlZ91RTaiOyfkJ50S3aCtrGi+lbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=01SyFk+mHRhHc/eEQ9o8LJ+6AZYy2NzGggePQEGtEHOV6TsUT+l0vMSbTY2f7XLhM 3gibXmlFuLJNt1qOaS5FBSdfaRw6HaaYUWbtFTSB2Bqf2BjfN+xzhTWE1qLgrBQU4G vS2ZN29myDgpcFiws55Aykl8MPgl93e2Uq/KPL2Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gopi Krishna Menon , Daniel Lezcano , Daniel Baluta , Lukasz Luba , Sasha Levin Subject: [PATCH 6.18 023/957] thermal/drivers/spear: Fix error condition for reading st,thermal-flags Date: Wed, 20 May 2026 18:08:26 +0200 Message-ID: <20260520162135.062145672@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gopi Krishna Menon [ Upstream commit da2c4f332a0504d9c284e7626a561d343c8d6f57 ] of_property_read_u32 returns 0 on success. The current check returns -EINVAL if the property is read successfully. Fix the check by removing ! from of_property_read_u32 Fixes: b9c7aff481f1 ("drivers/thermal/spear_thermal.c: add Device Tree probing capability") Signed-off-by: Gopi Krishna Menon Signed-off-by: Daniel Lezcano Suggested-by: Daniel Baluta Reviewed-by: Lukasz Luba Link: https://patch.msgid.link/20260327090526.59330-1-krishnagopi487@gmail.com Signed-off-by: Sasha Levin --- drivers/thermal/spear_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c index 603dadcd3df58..5e3e9c1f32f8e 100644 --- a/drivers/thermal/spear_thermal.c +++ b/drivers/thermal/spear_thermal.c @@ -93,7 +93,7 @@ static int spear_thermal_probe(struct platform_device *pdev) struct device_node *np = pdev->dev.of_node; int ret = 0, val; - if (!np || !of_property_read_u32(np, "st,thermal-flags", &val)) { + if (!np || of_property_read_u32(np, "st,thermal-flags", &val)) { dev_err(&pdev->dev, "Failed: DT Pdata not passed\n"); return -EINVAL; } -- 2.53.0