From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C84A3D6673; Wed, 20 May 2026 17:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297863; cv=none; b=PkAmKCxZhbtknpLxtTDIw8U1x1aIpDNYfhSDAIZQvRntXNDIne7ATNBP3emuy8teE8wAebmhWupPHEQmK28U9ISNcOxAKOb2ptilOJ5XN4tI1C1AFZMz5OLC1afVX4w0IGLcyE7aoGoYj/kMdSo8E4+XuVqDLKWesGL2BpAMgWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297863; c=relaxed/simple; bh=aOiBogHvFIbzUp4AyUwI49cR2lR5c+Kjpzn792H36Rc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B8TyzaT76tOhDLyf1s/Xnyl+fNYIt4Nk2JbNevBgFLRZfd41xaNk8uZF9UfNuJXUT3j8BRkoKOtpK9mJsTsdM/s8ENfozHuN4rCh8j1jXYUKNWs6Yxv3d1cM1Ak8c9pBU5gAxkRIg/NnmqEu2nO3HrIUJFWiZP7z+jWrTPEBaBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wDy7xtSv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wDy7xtSv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A92461F000E9; Wed, 20 May 2026 17:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779297862; bh=G929Gli6PmyvPBhHhKL8gXkU/TkXPrmyTWic3QoMGG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wDy7xtSv8gUV/2pZLp7ofn9U7a8d9gFhYQfjgaFS1LhRlWm4W6MoYU4F5y7HlUr53 6rGs/cStvhufMww/UXLD+MCw/vqXq5I1OBDvn0DoBg3qRooh0C0TyWwyImz2vXyGTN PDBjQG/jLPPYmNUIZFweADprAghNACRXPrKXZKaY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ethan Tidmore , Chen-Yu Tsai , Sasha Levin Subject: [PATCH 6.18 192/957] drm/sun4i: backend: fix error pointer dereference Date: Wed, 20 May 2026 18:11:15 +0200 Message-ID: <20260520162138.714018624@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ethan Tidmore [ Upstream commit 06277983eca4a31d3c2114fa33d99a6e82484b11 ] The function drm_atomic_get_plane_state() can return an error pointer and is not checked for it. Add error pointer check. Detected by Smatch: drivers/gpu/drm/sun4i/sun4i_backend.c:496 sun4i_backend_atomic_check() error: 'plane_state' dereferencing possible ERR_PTR() Fixes: 96180dde23b79 ("drm/sun4i: backend: Add a custom atomic_check for the frontend") Signed-off-by: Ethan Tidmore Reviewed-by: Chen-Yu Tsai Link: https://patch.msgid.link/20260217014801.60760-1-ethantidmore06@gmail.com Signed-off-by: Chen-Yu Tsai Signed-off-by: Sasha Levin --- drivers/gpu/drm/sun4i/sun4i_backend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c index 2dded3b828df0..0484cc27c97ae 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -490,6 +490,9 @@ static int sun4i_backend_atomic_check(struct sunxi_engine *engine, drm_for_each_plane_mask(plane, drm, crtc_state->plane_mask) { struct drm_plane_state *plane_state = drm_atomic_get_plane_state(state, plane); + if (IS_ERR(plane_state)) + return PTR_ERR(plane_state); + struct sun4i_layer_state *layer_state = state_to_sun4i_layer_state(plane_state); struct drm_framebuffer *fb = plane_state->fb; -- 2.53.0