From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 876CE2628D; Wed, 20 May 2026 17:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298280; cv=none; b=Ofy6wyIh1fzh3vlKFoidm7hoJHGZu8pdAlhA3HX1tpBzSrW1wpm7CeBGDD5VkroIApyDkqtu61NNAYNVmUFVNcBqHKqyQ+xlQoOn9ZxJLPAebtpZgeZQccUuhmTUEQb4psJgKJ5SFXW7WtNpmR4FHIC8BasSSgsSX/6REUs2sfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298280; c=relaxed/simple; bh=t7BFfffx49h0J7Dfi/YkOA1l2TCVZUXEe1reN6ozcWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EaaM0RmWiO1YsMJAB614GU9SswYvgtm6/g/KBuTUIQB95Vg66k3nL5Q3QHnP6dPacCXEc6p5pj+5AbzUHAqXxzB0C8kOZ/F9bXJnOFYxkwRyysH4wavOHc8uzAz4oqmH9gp/NcgPqm3z97bFiaDxFRPYh0u1T/9DBZdn1jWhdjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uXsSi5Dt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uXsSi5Dt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 005A91F000E9; Wed, 20 May 2026 17:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779298278; bh=OiR4AZYsTNauSGAUdHTICFaSFkfzMqW4TvVx+Yc4TF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uXsSi5Dt3SpQpSDI0Ns8aWqFvQ7UKjfRGB/BUIb3ItqjxFeFsU4ZZ7lcgcgIcXe5f +4wPIRInv45wkTQGrFQMCawSsQFIUX90JKPJNH3EK5lPFTgBh0EOcWZkgiW2SYM5bQ wZWmmGpll2akY+oJcmMTS6NYnvOZOuWjguMZvPX4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, John Hawley , Andrea Righi , Marcos Paulo de Souza , Matthieu Baerts , Fernando Fernandez Mancera , Pedro Falcato , "=?UTF-8?q?Ricardo=20B . =20Marli=C3=A8re?=" , Steven Rostedt , Sasha Levin Subject: [PATCH 6.18 348/957] ktest: Avoid undef warning when WARNINGS_FILE is unset Date: Wed, 20 May 2026 18:13:51 +0200 Message-ID: <20260520162142.077271261@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ricardo B. Marlière [ Upstream commit 057854f8a595160656fe77ed7bf0d2403724b915 ] check_buildlog() probes $warnings_file with -f even when WARNINGS_FILE is not configured. Perl warns about the uninitialized value and adds noise to the test log, which can hide the output we actually care about. Check that WARNINGS_FILE is defined before testing whether the file exists. Cc: John Hawley Cc: Andrea Righi Cc: Marcos Paulo de Souza Cc: Matthieu Baerts Cc: Fernando Fernandez Mancera Cc: Pedro Falcato Link: https://patch.msgid.link/20260307-ktest-fixes-v1-1-565d412f4925@suse.com Fixes: 4283b169abfb ("ktest: Add make_warnings_file and process full warnings") Signed-off-by: Ricardo B. Marlière Signed-off-by: Steven Rostedt Signed-off-by: Sasha Levin --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 88de775097fef..28643812184bc 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -2508,7 +2508,7 @@ sub check_buildlog { my $save_no_reboot = $no_reboot; $no_reboot = 1; - if (-f $warnings_file) { + if (defined($warnings_file) && -f $warnings_file) { open(IN, $warnings_file) or dodie "Error opening $warnings_file"; -- 2.53.0