From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A4A312825; Wed, 20 May 2026 17:34:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298500; cv=none; b=WrZnEOAK3teX7UJlieQIamOexWqXCQP1YZWa8bjiUEx57Dset4Gciy8Y8ppnPI0Ef82OAwaKh5Uoe9MeF4d/GNB8ADs45r8gxJa4CMRZvhRJsrXImQzzyOZ1wyYWpBEKo9qnpefHuK72coV1LTkS2R/C9u5stVuXR0b1h0yxHYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298500; c=relaxed/simple; bh=LiUatfy7N69wOpwJkUzMMVGNPz8n7F6fC7X2VjQ6v9w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rud9aMvslvKySGjHAd4pycZ60b7IU79LBybNs1/ztcoIKLyzHDQWTk6lf25k60n4HmJvmirotMPLBhjSqSzRrT9errv6evxxIAyooesphkT3TKX+xI/2FwXpHzYBTHD0z+GprAlixTKJuezgqhOPh93gQVSEsWAEQNyPvBePKPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eJJsN42P; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eJJsN42P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21B9E1F000E9; Wed, 20 May 2026 17:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779298499; bh=wmki7QZTxUebcyU+gUz8A22c1LSacHZ7MMvGvn6HyWE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eJJsN42PSnGPhmLD9S+cd99xsbXYXR36k8qCkfAHymWgQ4tbRCIFnblWPmqJjmmVM HUffAD5Pc6nHa/Te4wQVjTEuS7oKT031ySwAuElA9E7kG5BvWyRy6csFk11hfLtlGx bqDV7XCFnqNwMBhoQ8e8a7e0gn/Yx4GY5ZBoRVeY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alok Tiwari , Manivannan Sadhasivam , Konrad Dybcio , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.18 433/957] soc: qcom: llcc: fix v1 SB syndrome register offset Date: Wed, 20 May 2026 18:15:16 +0200 Message-ID: <20260520162143.911366100@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alok Tiwari [ Upstream commit 24e7625df5ce065393249b78930781be593bc381 ] The llcc_v1_edac_reg_offset table uses 0x2304c for trp_ecc_sb_err_syn0, which is inconsistent with the surrounding TRP ECC registers (0x2034x) and with llcc_v2_1_edac_reg_offset, where trp_ecc_sb_err_syn0 is 0x2034c adjacent to trp_ecc_error_status0/1 at 0x20344/0x20348. Use 0x2034c for llcc v1 so the SB syndrome register follows the expected +0x4 progression from trp_ecc_error_status1. This fixes EDAC reading the wrong register for SB syndrome reporting. Fixes: c13d7d261e36 ("soc: qcom: llcc: Pass LLCC version based register offsets to EDAC driver") Signed-off-by: Alok Tiwari Reviewed-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20260330095118.2657362-1-alok.a.tiwari@oracle.com Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/soc/qcom/llcc-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 857ead56b37d0..d5ce09d6115f0 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -3394,7 +3394,7 @@ static const struct llcc_slice_config x1e80100_data[] = { static const struct llcc_edac_reg_offset llcc_v1_edac_reg_offset = { .trp_ecc_error_status0 = 0x20344, .trp_ecc_error_status1 = 0x20348, - .trp_ecc_sb_err_syn0 = 0x2304c, + .trp_ecc_sb_err_syn0 = 0x2034c, .trp_ecc_db_err_syn0 = 0x20370, .trp_ecc_error_cntr_clear = 0x20440, .trp_interrupt_0_status = 0x20480, -- 2.53.0