From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88AB33D75D3; Wed, 20 May 2026 17:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298786; cv=none; b=XLRm45XLcG7bmH1v356alvCjHq2LmGdVRvCw64urDm/EUBBFhqBeReUvj7u0DEjetWolQ5Zitu2BI6b09AKXZkwxLUqWmGESzgE7xIUeZ2ytVlGlVZ2KzSstGE2slHUlioWBPWIep5qjXAs6vaQVnUpiG2HbisI/ABlEBEwMPVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298786; c=relaxed/simple; bh=lXGsHlgd3yY1gzUPBNQ0oGpm6AghPDxXEW0pV8QpzEQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bW41uXd18YT6rLfMTkwvH6Fi5SAE0pLCkug1BrmXf2dlB34BXXAQZ6ZfA1gd6ZORTd0MuaH8AsOXnmTD2T6Dp2Bxp1wiI5BL8ce7f4baKh00G8VwEccHHzcuH7/hdjM+Jl17eGe/YyXMfqi3ptCuhBEE3BgcXkt1iB/8QrKKco0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Zct/dljP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Zct/dljP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECEDB1F000E9; Wed, 20 May 2026 17:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779298785; bh=dcPXMVCPmqFEJjrZtnta9aI6nJfbaFZe+9GYXDcfwW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Zct/dljPOYsY4UhN6yHfcbr5FtkhBOip5XndZjDHrGdg+CiflHBEwvWIaU4dMV+ia XXwdDLlZx6ITHWX0QND9QHr9gskhnRJQnZXEOJiFoOvQfXf7E6LLOgzi/4oJbwabyD 9iIOdv5HYGDsZ5dOjcgRbEYoSbnz+VMYhgGYxOiY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fedor Pchelkin , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 6.18 544/957] platform/x86: dell_rbu: avoid uninit value usage in packet_size_write() Date: Wed, 20 May 2026 18:17:07 +0200 Message-ID: <20260520162146.331061364@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fedor Pchelkin [ Upstream commit f8fd138c2363c0e2d3235c32bfb4fb5c6474e4ae ] Ensure the temp value has been properly parsed from the user-provided buffer and initialized to be used in later operations. While at it, prefer a convenient kstrtoul() helper. Found by Linux Verification Center (linuxtesting.org) with Svace static analysis tool. Fixes: ad6ce87e5bd4 ("[PATCH] dell_rbu: changes in packet update mechanism") Signed-off-by: Fedor Pchelkin Link: https://patch.msgid.link/20260403134240.604837-1-pchelkin@ispras.ru [ij: add include] Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/dell/dell_rbu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/dell/dell_rbu.c index 403df9bd9522b..69d7c0a931a7c 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -30,6 +30,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include +#include #include #include #include @@ -619,9 +620,12 @@ static ssize_t packet_size_write(struct file *filp, struct kobject *kobj, char *buffer, loff_t pos, size_t count) { unsigned long temp; + + if (kstrtoul(buffer, 10, &temp)) + return -EINVAL; + spin_lock(&rbu_data.lock); packet_empty_list(); - sscanf(buffer, "%lu", &temp); if (temp < 0xffffffff) rbu_data.packetsize = temp; -- 2.53.0