From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7043336405A; Wed, 20 May 2026 17:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299073; cv=none; b=PPHv58uh3oXp97m/a1ZcopZjbr7Ai1Oh7T8VaEKb3BJXFhWho1rQ2L4nvcmWyF/DiuIdMmXF0qijpPacQyVs/rOlXn4SIxX1+f6m36/H4HjiUF0maJRGf30HwtdeP4J1rJsrPjCHYy6W7U1EhCZlRNVoJ1uXImPIm2F8gw/dyLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299073; c=relaxed/simple; bh=070WdoEYGFCO39sUbalkvINGS05h59oyMlZtXeQBPZQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vyn1Vl+YLGBkGgM5xf+k+IOFI9/HDCr1UeM8SeL45bpC13PDNp72vwOt/N0Q4G+fgNZ2KIcAS0fdOq+g39KkbZ4zgUj17jda02LyY4GVoHb60CHV6gAmk6JEaLPvmfrCtzkvL7Q6P9U+tbstTRsNe+9ehML//pT8/77oaTYlm0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TEO9mzgH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TEO9mzgH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB9441F000E9; Wed, 20 May 2026 17:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779299072; bh=gkgnaemR8oMgtN0ougQSnfV+UA3mNTfoEkU5NPcKtMI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TEO9mzgHzabw9ZfqyTRu1XrEssi2ZolUCSg3F5Toq+9zROxDVmlyTs8cSrZXe80Ok GN8L9pJkjPjTH/NzOvkgFwNDcEeGKhc4MY1T/Ov5npEixqMSYPGEtIgwLgBQZPi5l+ DP4Ba0mz3rZMiHGqz4SkmDKlIHtVesk1qs4UjknU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kohei Enju , Aleksandr Loktionov , Sunitha Mekala , Jacob Keller , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 651/957] i40e: dont advertise IFF_SUPP_NOFCS Date: Wed, 20 May 2026 18:18:54 +0200 Message-ID: <20260520162148.649797347@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kohei Enju [ Upstream commit a24162f18825684ad04e3a5d0531f8a50d679347 ] i40e advertises IFF_SUPP_NOFCS, allowing users to use the SO_NOFCS socket option. However, this option is silently ignored, as the driver does not check skb->no_fcs, and always enables FCS insertion offload. Fix this by removing the advertisement of IFF_SUPP_NOFCS. This behavior can be reproduced with a simple AF_PACKET socket: import socket s = socket.socket(socket.AF_PACKET, socket.SOCK_RAW) s.setsockopt(socket.SOL_SOCKET, 43, 1) # SO_NOFCS s.bind(("eth0", 0)) s.send(b'\xff' * 64) Previously, send() succeeds but the driver ignores SO_NOFCS. With this change, send() fails with -EPROTONOSUPPORT, as expected. Fixes: 41c445ff0f48 ("i40e: main driver core") Signed-off-by: Kohei Enju Reviewed-by: Aleksandr Loktionov Tested-by: Sunitha Mekala Signed-off-by: Jacob Keller Link: https://patch.msgid.link/20260416-iwl-net-submission-2026-04-14-v2-9-686c33c9828d@intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 598739220dfb9..9f19370f1c87a 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -13784,7 +13784,6 @@ static int i40e_config_netdev(struct i40e_vsi *vsi) netdev->neigh_priv_len = sizeof(u32) * 4; netdev->priv_flags |= IFF_UNICAST_FLT; - netdev->priv_flags |= IFF_SUPP_NOFCS; /* Setup netdev TC information */ i40e_vsi_config_netdev_tc(vsi, vsi->tc_config.enabled_tc); -- 2.53.0