From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ADCD3F1AD9; Wed, 20 May 2026 17:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299207; cv=none; b=fsUI+cN9bi47W6dA7okbe/lfGXwCb4cqNrPdSIoufl72Nw33j/vaF/2QgaF4FUTsPM5k7tyg5Dowh888n0/BhIOmNzKCFon9M7pR5hip02oejzfhFlRZooep7MeXVnyZp1xi+FqUfspTwVQYW2it6tXAZ+Vx2gMylMcjIaZ68cU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299207; c=relaxed/simple; bh=Gggvh/YcZAta1dEVwtWbolzVpwb/NLvOtCpfl+saTJY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kww7hJc0vSnYm6AYdSnJ2n+pvf/gkVHqjlJflI3cKLVC0D+e3HVWvndd09fauz6xTlvUjugAZaAzi7p2qgoZCZHXu+JdqB/WvLUnlW9FZExDuHBO3hhh3GNPgLg+66E/yyinXvwxCJttjipf2EPOdAqsCW3tg+gXQTaKRM0jOE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HtkvqmOd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HtkvqmOd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F20E31F00893; Wed, 20 May 2026 17:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779299206; bh=Xo5lzZgn1bfAKQCRYyK0vG9KFqemiqVVXOZ1OgiB5fQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HtkvqmOdoEOR7Wnvt+xICpvEP80J4HiOH7YftqRGqTr69A4NgKHjZjb7a61TLzH33 ZowUm7jnMGaydykOpCTlHkYXso82cLkYWR6hzlcUwlUPRk4xsYXv/OJKyvvk+OkJIJ JwD5b6DDIBT+1wUKgibX5BK0l2nCcW3KYe6VueTw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Erni Sri Satya Vennela , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 6.18 701/957] net: mana: Init link_change_work before potential error paths in probe Date: Wed, 20 May 2026 18:19:44 +0200 Message-ID: <20260520162149.741558273@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Erni Sri Satya Vennela [ Upstream commit cb4a90744bcd1adf12f0d0c7c4f0dd2647444ec5 ] Move INIT_WORK(link_change_work) to right after the mana_context allocation, before any error path that could reach mana_remove(). Previously, if mana_create_eq() or mana_query_device_cfg() failed, mana_probe() would jump to the error path which calls mana_remove(). mana_remove() unconditionally calls disable_work_sync(link_change_work), but the work struct had not been initialized yet. This can trigger CONFIG_DEBUG_OBJECTS_WORK enabled. Fixes: 54133f9b4b53 ("net: mana: Support HW link state events") Signed-off-by: Erni Sri Satya Vennela Link: https://patch.msgid.link/20260420124741.1056179-2-ernis@linux.microsoft.com Reviewed-by: Simon Horman Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index c770fb86fd2d3..cd3a435485a19 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3483,6 +3483,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) ac->gdma_dev = gd; gd->driver_data = ac; + + INIT_WORK(&ac->link_change_work, mana_link_state_handle); } err = mana_create_eq(ac); @@ -3500,8 +3502,6 @@ int mana_probe(struct gdma_dev *gd, bool resuming) if (!resuming) { ac->num_ports = num_ports; - - INIT_WORK(&ac->link_change_work, mana_link_state_handle); } else { if (ac->num_ports != num_ports) { dev_err(dev, "The number of vPorts changed: %d->%d\n", -- 2.53.0