From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEA71233933; Wed, 20 May 2026 17:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299360; cv=none; b=qt2kWAbHuG+8M9fKLklR73dZgZmsiP1p8I9G6JkvJksw9RKmXeFiefIIMb1kRFphbUB5OOm3WkRTx75Lob9vZzRF04X+4orzWrbaSawM0/uCHnmZYFS8CqUjTKOiu6wXk2RdinIKxHfxi+IAZkHLvdLICkyc3AkLQwGRxWPzjn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299360; c=relaxed/simple; bh=7prH0XWVD+7ymvTmENj1FrgzCi56dT5RoCM/PwqvfaI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JSvlrBNzubbuo7C1ktDB7FqGu5j1anDMDwEEWye3ZcJHTeMG35RzadZlniIRrorkmnVIL+7mrzAPtHF26+2sSfIL58f4uZ165LQVIKqyF/uW0Zzyqa42fbPe1QidH9Z+qEJZjinvseJ7+UPnxPvEh2v7u46YjQr2bqaKvytIpnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c5sZSd2Q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c5sZSd2Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01B111F00893; Wed, 20 May 2026 17:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779299358; bh=tUK3N5hLChq5rx6utF84pwBciP7y/ojzhmOV2TWUyuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=c5sZSd2Qqoe9HI3HlVaW+SgJdzMhbKDxdUXD44Cw+++sCp1c31G5FX9Zozb0BR0zM alYUimUngbi8WiY5OANC6wyXgdFoOadlcht+cpTyzCKXs28wvfSq6X1P+ktoq+WDFo iPUHfd8h0kQ7EMn+pYNCeGd/U+Wwkd/4t9ZAcaTg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qu Wenruo , Mark Harmstone , David Sterba , Sasha Levin Subject: [PATCH 6.18 741/957] btrfs: fix double-decrement of bytes_may_use in submit_one_async_extent() Date: Wed, 20 May 2026 18:20:24 +0200 Message-ID: <20260520162150.629855567@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Harmstone [ Upstream commit 82323b1a7088b7a5c3e528a5d634bff447fa286f ] submit_one_async_extent() calls btrfs_reserve_extent(), which decrements bytes_may_use. If the call btrfs_create_io_em() fails, we jump to out_free_reserve, which calls extent_clear_unlock_delalloc(). Because we're specifying EXTENT_DO_ACCOUNTING, i.e. EXTENT_CLEAR_META_RESV | EXTENT_CLEAR_DATA_RESV, this decreases bytes_may_use again. This can lead to problems later on, as an initial write can fail only for the writeback to silently ENOSPC. Fix this by replacing EXTENT_DO_ACCOUNTING with EXTENT_CLEAR_META_RESV. This parallels a4fe134fc1d8eb ("btrfs: fix a double release on reserved extents in cow_one_range()"), which is the same fix in cow_one_range(). Fixes: 151a41bc46df ("Btrfs: fix what bits we clear when erroring out from delalloc") Reviewed-by: Qu Wenruo Signed-off-by: Mark Harmstone Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index feaa6de8a90f2..5b99f2941f577 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -1208,7 +1208,7 @@ static void submit_one_async_extent(struct async_chunk *async_chunk, NULL, &cached, EXTENT_LOCKED | EXTENT_DELALLOC | EXTENT_DELALLOC_NEW | - EXTENT_DEFRAG | EXTENT_DO_ACCOUNTING, + EXTENT_DEFRAG | EXTENT_CLEAR_META_RESV, PAGE_UNLOCK | PAGE_START_WRITEBACK | PAGE_END_WRITEBACK); free_async_extent_pages(async_extent); -- 2.53.0