From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A76D36405A; Wed, 20 May 2026 17:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299365; cv=none; b=dnCwLry+9COOlBnlVPEP4e6sHIJ+GqDoO60FXQC4Q0tmKoSRUgx412dr2Qty9rczHYsMhG911nZ0O8FbfC7mZEZ47GtD5IFj3LLE1k4gHiHeooYPeHP5/rSwBEzRj/nyTQGNupxFBA+gBEszS1HZxz1/nhB9W1P2eAiO6Jskj7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299365; c=relaxed/simple; bh=IgdYDr9tdSzjVIgIBe2xPPi4zNSdWqPo4wFbFHpwbeY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xgou6BdWsc0e3QaiyMsGycqZhnmb9yeUlXq+YQGuf7LlkYsmB1K1zS8Kln05YOD5jOwTEENpIn/YgaTk20sZg+C8ytmlb0y53kVelCwPU2pVLt4k4My0Gcv8pXYGBTqMUcWSq/i0fTD+jIc1DaE+WyGx3YAG9LQZNH+/F4h9tnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ac/SShwr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ac/SShwr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 443171F000E9; Wed, 20 May 2026 17:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779299363; bh=UJNdaZMb7X75IQaGNEWZ1RIbEUB+AZ0DfS15C6ZemCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ac/SShwrF0O1Sgg4wIPE5JlTQ8tnIDLzDG6fCAOZD7p7CNvO9nuV3L+VbEYcQgDOq DJB+SI+Y1XnPeldM2soTvhcSFtD0u33hOfzxUB4EuMCpJMhmKut1reV0KyrN5ekOVm H7hkMDuIPDwhVowuW2tEBy6hKbU5B0fCfHOKcppQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mathieu Desnoyers , Ingo Molnar , Frederic Weisbecker , Breno Leitao , "Masami Hiramatsu (Google)" , Steven Rostedt , Sasha Levin Subject: [PATCH 6.18 743/957] tracing: branch: Fix inverted check on stat tracer registration Date: Wed, 20 May 2026 18:20:26 +0200 Message-ID: <20260520162150.673922299@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Breno Leitao [ Upstream commit 3b75dd76e64a04771861bb5647951c264919e563 ] init_annotated_branch_stats() and all_annotated_branch_stats() check the return value of register_stat_tracer() with "if (!ret)", but register_stat_tracer() returns 0 on success and a negative errno on failure. The inverted check causes the warning to be printed on every successful registration, e.g.: Warning: could not register annotated branches stats while leaving real failures silent. The initcall also returned a hard-coded 1 instead of the actual error. Invert the check and propagate ret so that the warning fires on real errors and the initcall reports the correct status. Cc: Mathieu Desnoyers Cc: Ingo Molnar Cc: Frederic Weisbecker Link: https://patch.msgid.link/20260420-tracing-v1-1-d8f4cd0d6af1@debian.org Fixes: 002bb86d8d42 ("tracing/ftrace: separate events tracing and stats tracing engine") Signed-off-by: Breno Leitao Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt Signed-off-by: Sasha Levin --- kernel/trace/trace_branch.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c index 6809b370e991d..d1564db95a8f5 100644 --- a/kernel/trace/trace_branch.c +++ b/kernel/trace/trace_branch.c @@ -373,10 +373,10 @@ __init static int init_annotated_branch_stats(void) int ret; ret = register_stat_tracer(&annotated_branch_stats); - if (!ret) { + if (ret) { printk(KERN_WARNING "Warning: could not register " "annotated branches stats\n"); - return 1; + return ret; } return 0; } @@ -438,10 +438,10 @@ __init static int all_annotated_branch_stats(void) int ret; ret = register_stat_tracer(&all_branch_stats); - if (!ret) { + if (ret) { printk(KERN_WARNING "Warning: could not register " "all branches stats\n"); - return 1; + return ret; } return 0; } -- 2.53.0