From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60A23D5647; Wed, 20 May 2026 17:50:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299456; cv=none; b=W+eHttAFtNG0u8T51K+A0JJWul7xCCiKYm/h3Aa+pHXWU3+0ZnTe+jWLgAz6q+JnjpLB4rRQhuBn5RfBD6p7EohL4qDP4YuoAblKp6RlPvQ6TpaJ+c3vEBOAwY93rhV/qi4QkT/4JTQA9nrHUmbYqJ8WYtGgdo3+UCLCpR7SVFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299456; c=relaxed/simple; bh=gHiADcNCdLLhE5NaHoIBeMf9e4mOEB4Kfb3g9x+zHSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CV8XJw/dDOU4vfNVaiRvCytXXeqAupW38mKRaXbg3TRfaZQQmK7HGJ4cgLX0R7D9VzfAiycnpbI7vkC7hF1McEvt8rPUgGZhhIG41z1TmLfkBuj58NS8FLYcujZSz6Dz/i90kd+dX8SuWgStw33nhK+Vd2SRzTFsE3BNHh5eXwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=D17lIY4+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="D17lIY4+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 388351F000E9; Wed, 20 May 2026 17:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779299455; bh=fmKfqhBlmYiwV/ko7bF4O3vbB0WwgoNCU+fkpIieYzM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=D17lIY4+W12CrO5iAvUKKUsHyU8xf3/05VQPQYvhvu6nh7u1NxqkMDE6feHaJskpB EsYxhQKeHbpcv9EmCND69q6YapuN5r9GPazuTeHfrs0I6s0zZ39nHS9ou4SquQfz4b jsZ0/ONq7qgzZREWmedF7cLoLiAcELV3bIPTqoso= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrew Lunn , Morduan Zang , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 779/957] net: usb: rtl8150: free skb on usb_submit_urb() failure in xmit Date: Wed, 20 May 2026 18:21:02 +0200 Message-ID: <20260520162151.454146853@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Morduan Zang [ Upstream commit adbe2cdf75461891e50dbe11896ac78e9af1f874 ] When rtl8150_start_xmit() fails to submit the tx URB, the URB is never handed to the USB core and write_bulk_callback() will not run. The driver returns NETDEV_TX_OK, which tells the networking stack that the skb has been consumed, but nothing actually frees the skb on this error path: dev->tx_skb = skb; ... if ((res = usb_submit_urb(dev->tx_urb, GFP_ATOMIC))) { ... /* no kfree_skb here */ } return NETDEV_TX_OK; This leaks the skb on every submit failure and also leaves dev->tx_skb pointing at memory that the driver itself may later free, which is fragile. Free the skb with dev_kfree_skb_any() in the error path and clear dev->tx_skb so no stale pointer is left behind. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reviewed-by: Andrew Lunn Signed-off-by: Morduan Zang Link: https://patch.msgid.link/E7D3E1C013C5A859+20260424015517.9574-1-zhangdandan@uniontech.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/rtl8150.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 8700ae392b10a..647f28b367b99 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -712,6 +712,13 @@ static netdev_tx_t rtl8150_start_xmit(struct sk_buff *skb, netdev->stats.tx_errors++; netif_start_queue(netdev); } + /* + * The URB was not submitted, so write_bulk_callback() will + * never run to free dev->tx_skb. Drop the skb here and + * clear tx_skb to avoid leaving a stale pointer. + */ + dev->tx_skb = NULL; + dev_kfree_skb_any(skb); } else { netdev->stats.tx_packets++; netdev->stats.tx_bytes += skb_len; -- 2.53.0