From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 008873C8723; Wed, 20 May 2026 16:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779295310; cv=none; b=U8gISuYPZTnIUYNnQteAaNcMMAD9ao1OApKX4tXZiXruRcJax+3fmKTYPvP0oTXrXl9ymmYF6j5gfgHLupkMK0ISdJsceT1nIovRLC8qMhZbNQn4k8LwJOHPhZmjBjFxSpCPRBT60zmOAqBtY3W3Blf6DW8OTikeHSso/Z3GAdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779295310; c=relaxed/simple; bh=IjmO4I7XOOJnuZtxXEda7nev727yRH//U5TJh8YfpJg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m/u5ReXDfaO15InSCHoEuY/3+yxL4O7mgeAk5XEnfYQ+76GSPGooraBynFME1t+LIkg8n0wnEZdstGXPdG7niSi60xpyuw22PaqYg+cwgK0BUlHgiiGsjrnLMnnOqtznyeb8UUk1eatJvm9QtMNUt1nUL0a8pDkeXho6lR2QKyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=f6j+kb0E; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="f6j+kb0E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 669331F000E9; Wed, 20 May 2026 16:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779295308; bh=1ZqCiDF1VTbsqeOs61YyzmDnMDLrpnyUscZf9C+Fxto=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=f6j+kb0ESwoIpetl0cbUhFS7LEt1ZYOXLCGJ6e8glaELs+tAFU4h5BoDeYPbwY7K+ gAKdm1oXFfTvDBUaCCwNFF7xDl4nphNQKHFHZrhze8KH0fofqpEhvT6iVR2ZPy4Z43 W6hm1d7aZX9uwHKnCj5gBRUls9An4VqmkCAeIg+k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Timur=20Krist=C3=B3f?= , Alex Deucher , Sasha Levin Subject: [PATCH 7.0 0343/1146] drm/amd/pm/ci: Fill DW8 fields from SMC Date: Wed, 20 May 2026 18:09:53 +0200 Message-ID: <20260520162155.962628241@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162148.390695140@linuxfoundation.org> References: <20260520162148.390695140@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Timur Kristóf [ Upstream commit baf28ec5795c077406d6f52b8ad39e614153bce6 ] In ci_populate_dw8() we currently just read a value from the SMU and then throw it away. Instead of throwing away the value, we should use it to fill other fields in DW8 (like radeon). Otherwise the value of the other fiels is just cleared when we copy this data to the SMU later. Fixes: 9f4b35411cfe ("drm/amd/powerplay: add CI asics support to smumgr (v3)") Signed-off-by: Timur Kristóf Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c index 9898c846c78e2..3650e7beeb671 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c @@ -543,12 +543,11 @@ static int ci_populate_dw8(struct pp_hwmgr *hwmgr, uint32_t fuse_table_offset) { struct ci_smumgr *smu_data = (struct ci_smumgr *)(hwmgr->smu_backend); const struct ci_pt_defaults *defaults = smu_data->power_tune_defaults; - uint32_t temp; if (ci_read_smc_sram_dword(hwmgr, fuse_table_offset + offsetof(SMU7_Discrete_PmFuses, TdcWaterfallCtl), - (uint32_t *)&temp, SMC_RAM_END)) + (uint32_t *)&smu_data->power_tune_table.TdcWaterfallCtl, SMC_RAM_END)) PP_ASSERT_WITH_CODE(false, "Attempt to read PmFuses.DW6 (SviLoadLineEn) from SMC Failed!", return -EINVAL); -- 2.53.0