From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C0483164C3; Wed, 20 May 2026 16:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296209; cv=none; b=TteJKEUMHAK0GEQlI4A7rA4Rs8Yg/JldI9pCnk2xlFxh9h1fFBIK2AIMkqFprijjXUlr2wiOC1fwjcH+u9A7UL26nFjaVqb9Ttur8Zn+ws6r1+OtY3hniDjMs4mriJ6zX681A9H9uyDqJKWziQG5gqN9cxaRkNi2K3ZmDAuj+ME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296209; c=relaxed/simple; bh=x7T/Oy3Bn+TcQXt2COt+kNhZqENNvYJ/RGQ8p+Yi0Lc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nn/jRzTpy9PWc93wX0b1CTOARyClOGRCs6/7g9zPNOAfwgwJ2q0xULpsi26Ny0NhJyuM3Wu50JyNWpHQj+hJ9jcPt+93Z76jiyrngwHqAN/MH/1HuAlGEScYJMzACru0mByalg/jYYIuLQ8NoNVWHp3ZSAAXzSCmHc2syjNkT2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Gsr3LBHO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Gsr3LBHO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B7B41F000E9; Wed, 20 May 2026 16:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779296207; bh=BPjkATWdwNm5KwrFupv+RWlvV4xfhWViLBikqGn0PXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Gsr3LBHO+GDS60Laku1e4DxZ5Rx9ItNyiHRDJo00F7z9TlY5vr9oHCzg+nHHRmuDX focJVRObHCtMHOgeS4/IuCwV61wkbZrGa8YPgictdFSZogF25IuzUGrlq91jaCEjJc +j0gNhrYWnyXhTMBv3FqtthmWjOlZbckY9q/2d2c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuhao Jiang , Junrui Luo , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 7.0 0712/1146] scsi: target: core: Fix integer overflow in UNMAP bounds check Date: Wed, 20 May 2026 18:16:02 +0200 Message-ID: <20260520162204.302256254@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162148.390695140@linuxfoundation.org> References: <20260520162148.390695140@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junrui Luo [ Upstream commit 2bf2d65f76697820dbc4227d13866293576dd90a ] sbc_execute_unmap() checks LBA + range does not exceed the device capacity, but does not guard against LBA + range wrapping around on 64-bit overflow. Add an overflow check matching the pattern already used for WRITE_SAME in the same file. Fixes: 86d7182985d2 ("target: Add sbc_execute_unmap() helper") Reported-by: Yuhao Jiang Signed-off-by: Junrui Luo Link: https://patch.msgid.link/SYBPR01MB7881593C61AD52C69FBDB0BDAF7CA@SYBPR01MB7881.ausprd01.prod.outlook.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_sbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index abe91dc8722e4..21f5cb86d70c0 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c @@ -1187,7 +1187,8 @@ sbc_execute_unmap(struct se_cmd *cmd) goto err; } - if (lba + range > dev->transport->get_blocks(dev) + 1) { + if (lba + range < lba || + lba + range > dev->transport->get_blocks(dev) + 1) { ret = TCM_ADDRESS_OUT_OF_RANGE; goto err; } -- 2.53.0