From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BB1037D101; Wed, 20 May 2026 16:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296219; cv=none; b=ngUn/pF+1YRFGBY7UIdQZ9HVe+MIcS1qxI3Or7OUL6qqmYGI7kvkRNRBayLg4l5nralet5fe7RAHNk6rxA7lS0ZlE/Mg5QxlDDYVXuHMlz3+jy08m3rUGiCwzdPJOHW3dtmIgoAV5K9+r2gHg2lqHr4QrVXqU0MtCMerwkb870Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296219; c=relaxed/simple; bh=gkfvhC2t51mhgL80+5pkWSduSvSNR7OfIGlPPpde+kw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mGpA7yf3y3ixw9jJcPsPtrtROq8bServaUVVPa+MJGmEyroQ6BKdDUiuoVuvIK+3C4nRwW4GNinSU3t+8aqXIZQS83ui6W47T35T7nItg3BeV59t9JvOuwGI3fLtkM68EQ+a9aICabEu8EeGq/ij5W9gY1nim82MMJpSu9281C0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LkP9VCXD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LkP9VCXD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F04CA1F000E9; Wed, 20 May 2026 16:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779296218; bh=4HQG+/MS1w05WEEnfV0MpWA4fOCGjRfiy210tD8XqUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LkP9VCXDsgOY0jfPXFNrCHfdgfhoIUaXFZH+/QFhbtmsEM8duLJPkgU7+/CHb+Fe4 7hostivRvHmnRVy3NewXvYv/mJqb5BMDLyyMrMfrZTeyLtzNzWkVxK7qjRG1M6pSsY kJkcgPn0co5X2yO6Xy8Z8zE/VEDswWukYv7l0PAY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Baryshkov , Konrad Dybcio , Val Packett , Bjorn Andersson , Sasha Levin Subject: [PATCH 7.0 0716/1146] clk: qcom: gcc-sc8180x: Use retention for USB power domains Date: Wed, 20 May 2026 18:16:06 +0200 Message-ID: <20260520162204.390734726@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162148.390695140@linuxfoundation.org> References: <20260520162148.390695140@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Val Packett [ Upstream commit 25bc96f26cd6c19dde13a0b9859183e531d6fbfc ] The USB subsystem does not expect to lose its state on suspend: xhci-hcd xhci-hcd.0.auto: xHC error in resume, USBSTS 0x401, Reinit usb usb1: root hub lost power or was reset (The reinitialization usually succeeds, but it does slow down resume.) To maintain state during suspend, the relevant GDSCs need to stay in retention mode, like they do on other similar SoCs. Change the mode to PWRSTS_RET_ON to fix. Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver for SC8180x") Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Val Packett Link: https://lore.kernel.org/r/20260312112321.370983-4-val@packett.cool Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/clk/qcom/gcc-sc8180x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c index 55dabf6259b29..b116a9c0b2d94 100644 --- a/drivers/clk/qcom/gcc-sc8180x.c +++ b/drivers/clk/qcom/gcc-sc8180x.c @@ -4172,7 +4172,7 @@ static struct gdsc usb30_sec_gdsc = { .pd = { .name = "usb30_sec_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, .flags = POLL_CFG_GDSCR, }; @@ -4190,7 +4190,7 @@ static struct gdsc usb30_prim_gdsc = { .pd = { .name = "usb30_prim_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, .flags = POLL_CFG_GDSCR, }; @@ -4262,7 +4262,7 @@ static struct gdsc usb30_mp_gdsc = { .pd = { .name = "usb30_mp_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + .pwrsts = PWRSTS_RET_ON, .flags = POLL_CFG_GDSCR, }; -- 2.53.0