From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228F93EFD14; Wed, 20 May 2026 17:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296515; cv=none; b=uCTSBwWZjLamgRpqTcbjxG3DAJo+daWRNDFp8gs2VFV4VpTXOYwb94PT8Q8UAxTvWE5XPkxLjhLLp6gqgjXQbOnKsqcX7DpAa8MmwK7OshiUDlr8zZzpeT9QrxIz8VBxNiAdUrPoQpH7LzldjRwKhUqHmD/7QmWJ2TBJDKEclbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296515; c=relaxed/simple; bh=hNCZOnR0pYgqi4hmsB3+qxj2IzP572f3yNaEaksUogE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TyKOxWP9VDIujpOKJqRf70zoVfK3ClU2j6WIgg1YoXiGReElFpGJJvGdUgvWZspZqMy5AWpYdvcYp1jDsTtRBCkQ9H+dVKsPzpVSJlGZoMRHu/KAmZqq6NGled9kNoK5G0cO8jDc8nxZsgmYZXu+beeADoKIKSoSb2P2SzWkTkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=E3S4a7Ud; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="E3S4a7Ud" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B5B11F00896; Wed, 20 May 2026 17:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779296514; bh=IPEqzashwUId1bw3vbb7PyxmvYRkZN2Fn5EB5NuU0No=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=E3S4a7UdH1GlWTKpb+PuwlbRBJu3S9RX1+cdoytTYIH3O0I/DpWwBt3hcVUuuW/yS kIwb1h6tVp4brBHnzobjRpaQ6dNNCYD1ix5SKKAhNbTmLXa1QPkjzMA31o8v76M8PR tbwjZ4+fZsnBOqnxRz6UOlUmA+oZ86l5tyw6XGHw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Akif , Namjae Jeon , Steve French , Sasha Levin Subject: [PATCH 7.0 0777/1146] ksmbd: fix use-after-free in smb2_open during durable reconnect Date: Wed, 20 May 2026 18:17:07 +0200 Message-ID: <20260520162205.800701618@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162148.390695140@linuxfoundation.org> References: <20260520162148.390695140@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Akif [ Upstream commit 1baff47b81f94f9231c91236aa511420d0e266b9 ] In smb2_open, the call to ksmbd_put_durable_fd(fp) drops the reference to the durable file descriptor early during the durable reconnect process. If an error occurs subsequently (eg, ksmbd_iov_pin_rsp fails) or a scavenger accesses the file, it leads to a use-after-free when accessing fp properties (eg fp->create_time). Move the single put to the end of the function below err_out2 so fp stays valid until smb2_open returns. Fixes: c8efcc786146 ("ksmbd: add support for durable handles v1/v2") Signed-off-by: Akif Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/smb/server/smb2pdu.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 135c74e6c4be6..e3a120a2d0596 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -3015,29 +3015,23 @@ int smb2_open(struct ksmbd_work *work) if (dh_info.reconnected == true) { rc = smb2_check_durable_oplock(conn, share, dh_info.fp, lc, sess->user, name); - if (rc) { - ksmbd_put_durable_fd(dh_info.fp); + if (rc) goto err_out2; - } rc = ksmbd_reopen_durable_fd(work, dh_info.fp); - if (rc) { - ksmbd_put_durable_fd(dh_info.fp); + if (rc) goto err_out2; - } fp = dh_info.fp; if (ksmbd_override_fsids(work)) { rc = -ENOMEM; - ksmbd_put_durable_fd(dh_info.fp); goto err_out2; } file_info = FILE_OPENED; rc = ksmbd_vfs_getattr(&fp->filp->f_path, &stat); - ksmbd_put_durable_fd(fp); if (rc) goto err_out2; @@ -3807,6 +3801,9 @@ int smb2_open(struct ksmbd_work *work) ksmbd_debug(SMB, "Error response: %x\n", rsp->hdr.Status); } + if (dh_info.reconnected) + ksmbd_put_durable_fd(dh_info.fp); + kfree(name); kfree(lc); -- 2.53.0