From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BCF320CAD; Sat, 30 May 2026 17:50:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163429; cv=none; b=uy/krMIcm0MZe9XXV+PDZBUaqi2kkmoK9y47CfvfleKDNpe6jteE/BxulieoVp0A6JcST+664/w0dJOW7lHRPqrx9HLgZ1/8ugmJENbjfID63IdJfxRtxbI5EwLaL2YcrEn+Y5Ea+96T6GgyzghTHXefdyuet3pBih5BGZO+7wA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163429; c=relaxed/simple; bh=ZW0AumUzoZcouFX1NmPpUog+g06rGRlOdnuilqo4phU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z/nAIw16dH5IosEoAKFm0WxZ2snmodXxOkCRU224IlQaWZCHNrToH2klyFyvYLjq6oDXpLYrZdsa8W/1phsYz95HblsYYlmEK6iyzRmOsg/I3zvANZ4gzkDv2lmknO01rzN+el3IlNrZd1o1zE4k02c3ikBr11jucj7lbo5kZxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pnMy9pd5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pnMy9pd5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13FFA1F00893; Sat, 30 May 2026 17:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780163428; bh=+z/XizA4u4dDn+zCNpeM84PRyfiJdVISEWEYvNP5J7o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=pnMy9pd5usnfu6w+DmbiawSCKxMU0Ao8EbH8HBjeJ1w2OKgDayBMX8MaX+ipawm1W c4Z635+MiZ3SK3vkaEqkv4e6FDyc+Vxf//y177QacPotaqtBB22tgi+TSSaIDW1Q0J oWw+BDlFHy6f6GFwQXwI5F8XORu/jxmAbNL1yNZk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thorsten Blum , Herbert Xu Subject: [PATCH 5.15 255/776] crypto: atmel-tdes - fix DMA sync direction Date: Sat, 30 May 2026 17:59:29 +0200 Message-ID: <20260530160247.124588632@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160240.228940103@linuxfoundation.org> References: <20260530160240.228940103@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thorsten Blum commit c8a9a647532f5c2a04180352693215e24e9dba03 upstream. Before DMA output is consumed by the CPU, ->dma_addr_out must be synced with dma_sync_single_for_cpu() instead of dma_sync_single_for_device(). Using the wrong direction can return stale cache data on non-coherent platforms. Fixes: 13802005d8f2 ("crypto: atmel - add Atmel DES/TDES driver") Fixes: 1f858040c2f7 ("crypto: atmel-tdes - add support for latest release of the IP (0x700)") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/atmel-tdes.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -304,8 +304,8 @@ static int atmel_tdes_crypt_pdc_stop(str dma_unmap_sg(dd->dev, dd->out_sg, 1, DMA_FROM_DEVICE); dma_unmap_sg(dd->dev, dd->in_sg, 1, DMA_TO_DEVICE); } else { - dma_sync_single_for_device(dd->dev, dd->dma_addr_out, - dd->dma_size, DMA_FROM_DEVICE); + dma_sync_single_for_cpu(dd->dev, dd->dma_addr_out, + dd->dma_size, DMA_FROM_DEVICE); /* copy data */ count = atmel_tdes_sg_copy(&dd->out_sg, &dd->out_offset, @@ -660,8 +660,8 @@ static int atmel_tdes_crypt_dma_stop(str dma_unmap_sg(dd->dev, dd->out_sg, 1, DMA_FROM_DEVICE); dma_unmap_sg(dd->dev, dd->in_sg, 1, DMA_TO_DEVICE); } else { - dma_sync_single_for_device(dd->dev, dd->dma_addr_out, - dd->dma_size, DMA_FROM_DEVICE); + dma_sync_single_for_cpu(dd->dev, dd->dma_addr_out, + dd->dma_size, DMA_FROM_DEVICE); /* copy data */ count = atmel_tdes_sg_copy(&dd->out_sg, &dd->out_offset,