From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801BB237713; Sat, 30 May 2026 17:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163732; cv=none; b=RJVtX/zze2xQL3kyoPCbeXAvzXMZGkTg4lr72WnrNEbpSnMpxbV32PTgyOxSYHs2mAQLkMumXiLc65+EQxaAEQHPbbFV15aaMAHA+kUugC87AYUxl2sS8JFvR7Ui8UBN+ObU4c9pi0AFEK9ipEIxWHF5Kzhv1OCZoHc5Yf4Yru8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163732; c=relaxed/simple; bh=urTmM4qvjAYLcXhgMSGrVC1bw6qSZvXH5iuxjVXbkEI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iIZXrjpMA49OGHxm2F/AvjVcq6qurbg9Z+ZlA3+/905Zwg1bkkUBfVuU/wpJp7RXHmLqintpJSDCBTRwFZGts4JJejPaYAV+2QmN+pGdAgKKp4klKLfBuA7E6XOIG53Z2DmhRzbKeKKEPv9IHsCoswXbimnp+uzHep43uiK4pjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AVhmaS1h; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AVhmaS1h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C381B1F00893; Sat, 30 May 2026 17:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780163731; bh=oRVHXULAITDfk8DAA3gkbFRTIhNUleVp412BS7LRaKA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AVhmaS1hKa1JqY1dz1wh9zolPxKtRPpb+uY1zbkYWqqrhiU/qmw2ETF2NJVh6fFI/ D5L77g6MsxDu7o9Oe5q24O6aIcPSUfO+IbNcoPk9Rg03ouAPvfJpFXQP5LC7PQvVT3 B4nssWH7emMhh1NgcKV5dErTQwXXU7ya8fbU8gW8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jason Gunthorpe Subject: [PATCH 5.15 345/776] RDMA/vmw_pvrdma: Fix double free on pvrdma_alloc_ucontext() error path Date: Sat, 30 May 2026 18:00:59 +0200 Message-ID: <20260530160249.495901145@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160240.228940103@linuxfoundation.org> References: <20260530160240.228940103@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jason Gunthorpe commit e38e86995df27f1f854063dab1f0c6a513db3faf upstream. Sashiko points out that pvrdma_uar_free() is already called within pvrdma_dealloc_ucontext(), so calling it before triggers a double free. Cc: stable@vger.kernel.org Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver") Link: https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4 Link: https://patch.msgid.link/r/10-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c @@ -350,7 +350,7 @@ int pvrdma_alloc_ucontext(struct ib_ucon uresp.qp_tab_size = vdev->dsr->caps.max_qp; ret = ib_copy_to_udata(udata, &uresp, sizeof(uresp)); if (ret) { - pvrdma_uar_free(vdev, &context->uar); + /* pvrdma_dealloc_ucontext() also frees the UAR */ pvrdma_dealloc_ucontext(&context->ibucontext); return -EFAULT; }