From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02FA7332EA7; Sat, 30 May 2026 17:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163869; cv=none; b=Sn/KWwjIxPB1mmUOSwcqvvL70/JvCWOFe/Ge5SflGwY4ZRnMLQAcigGq57u2aL3GegtyJxAtKepYTsWmCjqfdeLaco6p+LWkYHMwNmeHQlj6yUpSaxT46jW1dg3XU/DNJhCd4tzKvmn+oq8/tb7hAFbKt19Of5FQg2d2nKi6hgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163869; c=relaxed/simple; bh=5m3WYXif7NtGOJmAwdpPJ4aajzbC+golriBFZRTP1cU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WVVEoTul35z8LZXuNHHFisX56betUxpVvk1MRlyRNYB0MeOXDSyUu3t9ucI5jqojt0/w9uTwVE+1babRTwdKp+pDC1WpiT0cHwkcpFmQB9k6TmbbL9Gg6j9vsRep7HVUVswmb4ZliveRtG5qK42Egt9X3L5wJo6BLxe72NztT6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1MKBOCVJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1MKBOCVJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D43711F00893; Sat, 30 May 2026 17:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780163868; bh=oLc/qX6sIKVJEMSQqXJfEpelueygEV8D7xiVsKh/baY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1MKBOCVJuueFZqOIdoc26rtkzgp3LUTt87a9IXz/5L6m9sLJaTg12kuPcjwHizGwK XS1CsSsnjpbpyiv6ezbyZ+fhK8APbl21PiJB16NVS8fU2R3/SIeZSQ05dlslZRc6Rf MVQ+Sm/FILSQiiUPaB1FIjEh/SLYkyR1l88NLc9E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Christoph Hellwig , Andreas Gruenbacher , Bart Van Assche , Jens Axboe , Sasha Levin Subject: [PATCH 5.15 386/776] drbd: Balance RCU calls in drbd_adm_dump_devices() Date: Sat, 30 May 2026 18:01:40 +0200 Message-ID: <20260530160250.481664448@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160240.228940103@linuxfoundation.org> References: <20260530160240.228940103@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bart Van Assche [ Upstream commit 2b31e86387e60b3689339f0f0fbb4d3623d9d494 ] Make drbd_adm_dump_devices() call rcu_read_lock() before rcu_read_unlock() is called. This has been detected by the Clang thread-safety analyzer. Tested-by: Christoph Böhmwalder Reviewed-by: Christoph Hellwig Cc: Andreas Gruenbacher Fixes: a55bbd375d18 ("drbd: Backport the "status" command") Signed-off-by: Bart Van Assche Link: https://patch.msgid.link/20260326214054.284593-1-bvanassche@acm.org Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/drbd/drbd_nl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 69184cf17b6ad..6d2093c2c51b7 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -3424,8 +3424,10 @@ int drbd_adm_dump_devices(struct sk_buff *skb, struct netlink_callback *cb) if (resource_filter) { retcode = ERR_RES_NOT_KNOWN; resource = drbd_find_resource(nla_data(resource_filter)); - if (!resource) + if (!resource) { + rcu_read_lock(); goto put_result; + } cb->args[0] = (long)resource; } } @@ -3674,8 +3676,10 @@ int drbd_adm_dump_peer_devices(struct sk_buff *skb, struct netlink_callback *cb) if (resource_filter) { retcode = ERR_RES_NOT_KNOWN; resource = drbd_find_resource(nla_data(resource_filter)); - if (!resource) + if (!resource) { + rcu_read_lock(); goto put_result; + } } cb->args[0] = (long)resource; } -- 2.53.0