From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3733829B78B; Sat, 30 May 2026 18:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780164216; cv=none; b=YGiym6Y4YIuhyguBgLt/3q+Qav0KKhYqpTYHghMlbpbbS0Jk5z76c4KZQCEfWGuh/qielTzgThmwwh3z+kS82wbExvozZ2peqBUBzR33i0WquYRjZ/uTDyfKTxj1BZLOA4meHm9vcI5LguBYAhC76+UEAPaP+ZzdEo6EwWysq+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780164216; c=relaxed/simple; bh=S359eRj5BEOLDi8TLokZQXiOits3lvw6O5/n5lx9fDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GUW+nkJ9WiAU1EZspWphU+IJAH+xsvpwKu4/Pnt6GqGHuxQKl/mzuQ95urbzoLC2Dt7ZroAHhMwJcjxMhlSzCR1Sl2gNa8msatdefAgXv3CZBCjH6S/V2W9TxLGdgvMVj5N53OXxFecEFMgw+EWpI6HNSPiYHgoZpVgImwePqFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z/PGrQAV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z/PGrQAV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BD841F00893; Sat, 30 May 2026 18:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780164215; bh=mstB/X2L1+R0dlrvjT/eeVHK4B1oAK8PaltDaneBRzU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z/PGrQAVHIyezmINkcU8YHHvuIjyu/sKI+vsB7xvvDMvc3xu7AgJQ9f6bNWB6VNPc RaLY7FhLm4wGp1TMik1zef0lv1Uj6w8Jg3xTxfVGNzzvLiavmglS/YtU2BKPE+lD8+ Qtlga+VhZ386DOAszn5UrlmI8XpkmZc0l8W+6VlY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mikko Perttunen , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 5.15 488/776] memory: tegra30-emc: Fix dll_change check Date: Sat, 30 May 2026 18:03:22 +0200 Message-ID: <20260530160252.934615836@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160240.228940103@linuxfoundation.org> References: <20260530160240.228940103@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mikko Perttunen [ Upstream commit 0a93f2355cf4922ad2399dbef5ea1049fef116d4 ] The code checking whether the specified memory timing enables DLL in the EMRS register was reversed. DLL is enabled if bit A0 is low. Fix the check. Fixes: e34212c75a68 ("memory: tegra: Introduce Tegra30 EMC driver") Signed-off-by: Mikko Perttunen Link: https://patch.msgid.link/20260126-fix-emc-dllchange-v1-2-47ad3bb63262@nvidia.com Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin --- drivers/memory/tegra/tegra30-emc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c index 7e21a852f2e1f..ed4b74540714e 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -539,14 +539,14 @@ static int emc_prepare_timing_change(struct tegra_emc *emc, unsigned long rate) emc->emc_cfg = readl_relaxed(emc->regs + EMC_CFG); emc_dbg = readl_relaxed(emc->regs + EMC_DBG); - if (emc->dll_on == !!(timing->emc_mode_1 & 0x1)) + if (emc->dll_on == !(timing->emc_mode_1 & 0x1)) dll_change = DLL_CHANGE_NONE; - else if (timing->emc_mode_1 & 0x1) + else if (!(timing->emc_mode_1 & 0x1)) dll_change = DLL_CHANGE_ON; else dll_change = DLL_CHANGE_OFF; - emc->dll_on = !!(timing->emc_mode_1 & 0x1); + emc->dll_on = !(timing->emc_mode_1 & 0x1); if (timing->data[80] && !readl_relaxed(emc->regs + EMC_ZCAL_INTERVAL)) emc->zcal_long = true; -- 2.53.0