From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA1824EA90; Sat, 30 May 2026 18:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165208; cv=none; b=MJJ72fMSszLeK1G63G/71eJ3+lGjWBIWNJcW5tHNikEPxr6jqq1BE0RtlubJnvUmTw7Lh40OYk1AE/szwvmXm81vjmaHNZXZmVFJqNZ1tM2ueqYIaGv/qgAipSshXKZILIPC1hdNq/jhFcPZjU9kSNnEfyXDzf+9wZwGA9qU7Zg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165208; c=relaxed/simple; bh=p/7q4jrfmElQ3iwCbgrqbpDKgTTed0isoQf28QzdwFE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N5jnQrBAutzQElXTzE0Pmylw6fbvHJ1i4qI+r9ZsMSKj9DjWc222JGTyFIGINbuyct/O1ClpRCIwXb9g65Hwh2vmi4C5s1oglLiswYsQeG/El+UhEGUHwTqNDDcZY+ywczaFNQwWyDnNgvfmBeBZuTJcFTmywvzZtDyXSo3jFzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OY0mZIt0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OY0mZIt0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ECED1F00893; Sat, 30 May 2026 18:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165207; bh=d0aHds9JWfaOuU4Bwt49cmpJgplpjU5/3C+GgLJajuk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OY0mZIt0trEtabGtjLzpgrz2uC4LyYtk+wzuMW9rZepRr6ia6F/x5ZXXMATYPrT32 ZoWKx8+Xt8sDFMT8bTPQK7FeJ+zPTkYC/sOln1kpsfFFW1/N9PijG7ClGzCLS2aMF3 9Xvn6E9VAmG5xIKp/9WW+lMFfSnrDwyMeHjYQDc0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chenguang Zhao , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 754/776] ethtool: fix ethnl_bitmap32_not_zero() bit interval semantics Date: Sat, 30 May 2026 18:07:48 +0200 Message-ID: <20260530160259.241038511@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160240.228940103@linuxfoundation.org> References: <20260530160240.228940103@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chenguang Zhao [ Upstream commit 3d042592ebd4c7e44974d556de0b727cb7db4dab ] ethnl_bitmap32_not_zero() should return true if some bit in [start, end) is set: - Fix inverted memchr_inv() sense: return true when the scan finds a non-zero byte, not when the middle words are all zero. - Return false for an empty interval (end <= start). - When end is 32-bit aligned, indices in [start, end) do not include any bits from map[end_word]; return false after earlier checks found no non-zero data. Fixes: 10b518d4e6dd ("ethtool: netlink bitset handling") Signed-off-by: Chenguang Zhao Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ethtool/bitset.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ethtool/bitset.c b/net/ethtool/bitset.c index f0883357d12e5..4691d6d0f2b75 100644 --- a/net/ethtool/bitset.c +++ b/net/ethtool/bitset.c @@ -91,7 +91,7 @@ static bool ethnl_bitmap32_not_zero(const u32 *map, unsigned int start, u32 mask; if (end <= start) - return true; + return false; if (start % 32) { mask = ethnl_upper_bits(start); @@ -104,11 +104,11 @@ static bool ethnl_bitmap32_not_zero(const u32 *map, unsigned int start, start_word++; } - if (!memchr_inv(map + start_word, '\0', - (end_word - start_word) * sizeof(u32))) + if (memchr_inv(map + start_word, '\0', + (end_word - start_word) * sizeof(u32))) return true; if (end % 32 == 0) - return true; + return false; return map[end_word] & ethnl_lower_bits(end); } -- 2.53.0