From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63BA734E745; Sat, 30 May 2026 16:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780159811; cv=none; b=SaYis+xKBbaK/WZcoLMXqJfr+slZW+hFgS+puTb4vC3q4f/Hw15vmWWYZsGnI0yXE0+USzd+siyLjh2+YAkJaAa9vhy3YB72j/sOqUhGk61WqkhCShifSPoqh4KCi86AIrSM/c1IwTHuoAeG+GfiY3EcwrmJ0LUxBNdsgTY7b5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780159811; c=relaxed/simple; bh=g6MUd+gzeg2QmzNtyXNyRmObR8fx+PCHG3873Ykn6v0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O48EX/Dw+J3S1/xCbRVMMKACuA0OXTi+LrdGKIUN7glsyUzTiSOnJjpfC+xV4s9gMTPzHn9K5MzobV+mhy8mxJEvqQV/OWNMsmajtdDebfHIda9wfu0yYtu93Lcum09HLaQMjwDQAqNXERoltRwoirTy19BAfZnbeBFFIeTZw3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zKsDmNiN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zKsDmNiN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A84331F00893; Sat, 30 May 2026 16:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780159810; bh=zy0ThBdZ8Ad217ix94mgPISi2dCBX17BZ04os/4ItKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zKsDmNiN+CHQR1E9E0Li2RQnZ1IM/MogCllaX7QOMrzFgUQ3ZVY/UGqQyiAk81qZQ hAxi3shLoO5g4fq8v5n3dV/KSF0yXo7CtRHGyOARg4SjRrdkEKuD8w79OSKlFnDgcn DeMqRqO4pZEcmk5k+nIZGU2/zR93HD86qix15Sro= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , Takashi Iwai Subject: [PATCH 6.1 160/969] ALSA: usb-audio: Avoid false E-MU sample-rate notifications Date: Sat, 30 May 2026 17:54:44 +0200 Message-ID: <20260530160304.948701298@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160300.485627683@linuxfoundation.org> References: <20260530160300.485627683@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cássio Gabriel commit fca9c850042a7ab4828ce3a9caa8bc40ea09856a upstream. snd_emuusb_set_samplerate() unconditionally notifies the E-MU SampleRate Extension Unit control after issuing SET_CUR. If snd_usb_mixer_set_ctl_value() fails, the control value has not changed, yet snd_usb_mixer_notify_id() still invalidates the cache and emits a value-change event to userspace. Notify the control only after a successful write. Fixes: 7d2b451e65d2 ("ALSA: usb-audio - Added functionality for E-mu 0404USB/0202USB/TrackerPre") Cc: stable@vger.kernel.org Signed-off-by: Cássio Gabriel Link: https://patch.msgid.link/20260421-alsa-emuusb-samplerate-notify-v1-1-8b63bbc1d7f1@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/mixer_quirks.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -1561,15 +1561,17 @@ void snd_emuusb_set_samplerate(struct sn { struct usb_mixer_interface *mixer; struct usb_mixer_elem_info *cval; + int err; int unitid = 12; /* SampleRate ExtensionUnit ID */ list_for_each_entry(mixer, &chip->mixer_list, list) { if (mixer->id_elems[unitid]) { cval = mixer_elem_list_to_info(mixer->id_elems[unitid]); - snd_usb_mixer_set_ctl_value(cval, UAC_SET_CUR, - cval->control << 8, - samplerate_id); - snd_usb_mixer_notify_id(mixer, unitid); + err = snd_usb_mixer_set_ctl_value(cval, UAC_SET_CUR, + cval->control << 8, + samplerate_id); + if (!err) + snd_usb_mixer_notify_id(mixer, unitid); break; } }