From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA1B533F5A3; Sat, 30 May 2026 16:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160110; cv=none; b=LqkGpL7Vu839gidXXY9UAzyNm1Af4QWd6IayBf8rgbuQXB3SfXn7zKLJWxEubroDqHxhDrVZmbXh+2xMp/JaqP2LmM0gK1qk17fteqvgisoJ/ChRU8ULMNJqrtABg22rIXlpsErrgciRoJuXIrEoOOAFKnY2ht46At89ZcuX9f4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160110; c=relaxed/simple; bh=F3hm1FVLbI3vgMAWUunpe2/kbwSUthaeushk+3gNbbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QrkYxTlVF17bDJmAcYEXwnaCbnWSVNNehbb53aDj4uAn2MKO/Lok0QaaQ6Uamtp+aVuTnoz7py0S7dx32cnlNoSPtAMStpT+4kg14zil62hq4fOdZ+9Ef46vcdKKV3ZN/TCL5mPg4XlpObgBlWZGUMC6ofgOH1zCVQFVrxhC8uE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=F0eyp84M; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="F0eyp84M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28B5F1F00893; Sat, 30 May 2026 16:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780160109; bh=Hq3ITEbRiLGnpQ2QcDunhy7Rv/sje2A6jZIozubA+0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=F0eyp84MZ9MIfajk09K5POnH/RbVgeFUUUIsf5QTUo8IbktkXIAgXrYIjF/Uj5lRY 9QH3Bs1/zPSHyqpCeGeUmDW6RpPh8yHIufP6qoUSiJC35vcjg0OwmxTL5f70EkmFT7 6t686hGv4SFCb9FxUt4CfU48w5+i+HUmBdQfFQWc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sohei Koyama , Andreas Dilger , "Ritesh Harjani (IBM)" , Zhang Yi , Baokun Li , Theodore Tso Subject: [PATCH 6.1 247/969] ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all() Date: Sat, 30 May 2026 17:56:11 +0200 Message-ID: <20260530160307.286911835@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160300.485627683@linuxfoundation.org> References: <20260530160300.485627683@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sohei Koyama commit 77d059519382bd66283e6a4e83ee186e87e7708f upstream. The commit c8e008b60492 ("ext4: ignore xattrs past end") introduced a refcount leak in when block_csum is false. ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to get iloc.bh, but never releases it with brelse(). Fixes: c8e008b60492 ("ext4: ignore xattrs past end") Signed-off-by: Sohei Koyama Reviewed-by: Andreas Dilger Reviewed-by: Ritesh Harjani (IBM) Cc: stable@vger.kernel.org Reviewed-by: Zhang Yi Reviewed-by: Baokun Li Link: https://patch.msgid.link/20260406074830.8480-1-skoyama@ddn.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/xattr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1112,7 +1112,7 @@ ext4_xattr_inode_dec_ref_all(handle_t *h { struct inode *ea_inode; struct ext4_xattr_entry *entry; - struct ext4_iloc iloc; + struct ext4_iloc iloc = { .bh = NULL }; bool dirty = false; unsigned int ea_ino; int err; @@ -1207,6 +1207,8 @@ ext4_xattr_inode_dec_ref_all(handle_t *h ext4_warning_inode(parent, "handle dirty metadata err=%d", err); } + + brelse(iloc.bh); } /*