From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5254CB5B; Sun, 7 Jun 2026 10:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780827677; cv=none; b=Uqneg/9jpZfO4vuiLWH1hHEWx+dbYTSsw4siCgWYMcdr6HNtsHqQHpCiqJg3NAuKP5JBQ20f4b4KzAo5JqGYkInciuf3JOZb8Dwxs+qkzMBdcCX1vO5Ao2jnkK4fZLLqTJrsxXXCNausdjnMcxfAy348GH482R2fX2V+CrkSGgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780827677; c=relaxed/simple; bh=djqOYN+5jCdMIVrZ0oS/no05LQ332Dr0ZuYz0yTkuFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gNJW0v5AKQQc5EJyF/vO3nyx/HV/3BCGiV/tuMQyEdYEwhMO1ymcnYh62MdxHOQBZx1m8zHjPKjorcE9WpVTfkQsw7+BxM3ZpyvNjFf6jNCpcseL1hrMcCVA8JaOagdV/zAlqGrxhE5zTcYLHQ93VF7TnfBQQyxTqM1a2GnJSuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BgDKTnp9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BgDKTnp9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 853EB1F00893; Sun, 7 Jun 2026 10:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780827676; bh=zhQJ07F5/LyTAR+ZcIDxHUqE89GH8L9x+gQV3casGH8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BgDKTnp9g0sp6w+1GbaUK+GzM25B3rpSLb6/AuRGj3wprqwCCCCi0hRfJXX8fw9oQ pNNdU/dIrU6xWnaunPCjVXlGnUFQ0i8CstnGyqMh3xi4RStwgUfVKT78YOZalpwkop yvzho1vtGcVfeVzta2gSK0zTznXd4sfBD4AjKCsg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiayuan Chen , Ido Schimmel , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 092/315] ipv6: fix possible infinite loop in rt6_fill_node() Date: Sun, 7 Jun 2026 11:57:59 +0200 Message-ID: <20260607095731.008528916@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095727.528828913@linuxfoundation.org> References: <20260607095727.528828913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiayuan Chen [ Upstream commit 9f72412bcf60144f252b0d6205106abf14344abc ] Sashiko reported this issue [1]. Apply the same fix as commit f8d8ce1b515a ("ipv6: fix possible infinite loop in fib6_info_uses_dev()"). Writers holding tb6_lock can list_del_rcu(&rt->fib6_siblings) without waiting for RCU readers; rt->fib6_siblings.next then still points into the old ring and this softirq-side walker never reaches &rt->fib6_siblings, causing a CPU stall. fib6_del_route() always WRITE_ONCE()s rt->fib6_nsiblings to 0 before list_del_rcu(), so an inside-loop check is a reliable detach signal. [1] https://sashiko.dev/#/patchset/20260526020227.4857-1-jiayuan.chen%40linux.dev Fixes: d9ccb18f83ea ("ipv6: Fix soft lockups in fib6_select_path under high next hop churn") Signed-off-by: Jiayuan Chen Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/20260527053133.180695-1-jiayuan.chen@linux.dev Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv6/route.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 446f4de7d6a227..cf9546047b5749 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5892,6 +5892,8 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, goto nla_put_failure; } + if (!READ_ONCE(rt->fib6_nsiblings)) + break; } rcu_read_unlock(); -- 2.53.0