From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26E3D13777E; Tue, 16 Jun 2026 18:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635352; cv=none; b=bMCgKjn6AmHpZWOc3DpdhKKG1+/jhtRyULDeWz48T/Sirl+e88MUH0Fvkfmlp+9ZPDG0bFo/45QcXcFq0q37J8jxwPy0rQO311mO7HJM6RSIjlHt7NLt3FbWDL3W/UwjFJg5xUqK94aGjUbmt2uJqccMOChtE0jK6DnyEuPQZwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635352; c=relaxed/simple; bh=Do+zy++bAIDPhbl7u7lhW+3PUYYuOHyOmi6Ch6vJfJY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pFFPUvOQ3ffPoQnP/+slj5tTd1kWRH2CaeqLOzSstcUkWtmqpw+QMcD3ra4EhqLIOuwC+tFkoKbgJB7Lbv0zybjqophD1lacCe1vqv8rh0FtV98eT7jP32x3LiAxzkDcZY3xTQ4jT7h+p7wmpFNbUQfq8PrcIlZqka7fN6VgD/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d0JOUlAi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d0JOUlAi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B48731F000E9; Tue, 16 Jun 2026 18:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781635350; bh=hj9/syPbwBlJ9OS0iHn6fOOGL0ldaek1nAPTi0g30n8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=d0JOUlAiv6xUQ2Q7GhARsZByILX/1a+d1VxDbOMNhnFUvqwGCYqBXcAlE+njuBwSV lbCXPsX8Su5SFdye9tRVpvDuKzihveVIHLAM2uYZ1AhNT0sdyVsH6sulEDayR+VZ7c zvTTyWUTADiP9GBMxBYUP8rupuXJeczlXyP0RsKk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ilya Maximets , Nicolas Dichtel , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 015/342] net: netlink: fix sending unassigned nsid after assigned one Date: Tue, 16 Jun 2026 20:25:11 +0530 Message-ID: <20260616145049.001783246@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilya Maximets [ Upstream commit 70f8592ee90585272018a725054b6eb2ab7e99ca ] If the current skb is not shared, it is re-used directly for all the sockets subscribed to the notification. If we have remote all-nsid socket receiving a message first, then the 'nsid_is_set' will be set to 'true'. If the nsid is NOT_ASSIGNED for the next socket in the list, the 'nsid_is_set' will remain 'true' and the negative value is be delivered to the user space. All subsequent nsid values will be delivered as well, since there is no code path that sets the flag back to 'false'. Fix that by always dropping the flag to 'false' first. Fixes: 7212462fa6fd ("netlink: don't send unknown nsid") Signed-off-by: Ilya Maximets Acked-by: Nicolas Dichtel Link: https://patch.msgid.link/20260520172317.175168-2-i.maximets@ovn.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/netlink/af_netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 42b7b8574f0994..e8301a36926275 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1478,6 +1478,7 @@ static void do_one_broadcast(struct sock *sk, p->skb2 = NULL; goto out; } + NETLINK_CB(p->skb2).nsid_is_set = false; NETLINK_CB(p->skb2).nsid = peernet2id(sock_net(sk), p->net); if (NETLINK_CB(p->skb2).nsid != NETNSA_NSID_NOT_ASSIGNED) NETLINK_CB(p->skb2).nsid_is_set = true; -- 2.53.0