From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3368B38C437; Tue, 16 Jun 2026 18:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635404; cv=none; b=SU3nNFCq7LJsvRUdaDeIPf604W5p02uKA/geHpmTlxjGXO2lIr3FNidAlW3n8OpbAi9u6m4lQqlVgfyo4MVxB5aUX7kCHA39b5kDrRi3uthuiUkUiezGOHz1F725V2Ov18BmOWORsDEaJD74q9/XHB9SE021i7LvzYDUIu5fb1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635404; c=relaxed/simple; bh=r4qBZhwyF7arc/ufC7qm7AS0Y1+1l3VRlkEXgb3VUnc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B0fIwreOarLG47Pq0MSa5kAnBOzfpoA09xHJd44yWMjk3A59P5go/66hI/A+HVJZy04wkSZBRrQwkxw3uZiXpvnBbte5v+K+MEuPRGVdyTseVQGGy3LF4LmCspJmi987RQZZshtesyle//acbm/GAq6exZ7UuKv7gVp1NRhFeDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=j4JCJQ8U; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="j4JCJQ8U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECB941F000E9; Tue, 16 Jun 2026 18:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781635402; bh=1o/QQzJq8YDLLUYW9rBZMZ4HBlEMhmHEs9UdFMCVKLI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=j4JCJQ8Udj9E7CfofIMHiaJwS0YaX52qkWvK29qnNsABWNRJlcTJ64Jt9G5RUrVhR sq8KqPr6zyT9h1okC6fN4nhZ8nfEHBINO4DsQXoHK/WTGc+O9gGu9znkUQh1jfw7J0 Aj1HvFeA8fylkqJpOaM33EXZZbUsweFGq8BRlW1c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiasheng Jiang , Zhu Yanjun , Leon Romanovsky , Ben Hutchings , Sasha Levin Subject: [PATCH 5.10 042/342] RDMA/rxe: Fix double free in rxe_srq_from_init Date: Tue, 16 Jun 2026 20:25:38 +0530 Message-ID: <20260616145050.215416962@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiasheng Jiang commit 0beefd0e15d962f497aad750b2d5e9c3570b66d1 upstream. In rxe_srq_from_init(), the queue pointer 'q' is assigned to 'srq->rq.queue' before copying the SRQ number to user space. If copy_to_user() fails, the function calls rxe_queue_cleanup() to free the queue, but leaves the now-invalid pointer in 'srq->rq.queue'. The caller of rxe_srq_from_init() (rxe_create_srq) eventually calls rxe_srq_cleanup() upon receiving the error, which triggers a second rxe_queue_cleanup() on the same memory, leading to a double free. The call trace looks like this: kmem_cache_free+0x.../0x... rxe_queue_cleanup+0x1a/0x30 [rdma_rxe] rxe_srq_cleanup+0x42/0x60 [rdma_rxe] rxe_elem_release+0x31/0x70 [rdma_rxe] rxe_create_srq+0x12b/0x1a0 [rdma_rxe] ib_create_srq_user+0x9a/0x150 [ib_core] Fix this by moving 'srq->rq.queue = q' after copy_to_user. Fixes: aae0484e15f0 ("IB/rxe: avoid srq memory leak") Signed-off-by: Jiasheng Jiang Link: https://patch.msgid.link/20260112015412.29458-1-jiashengjiangcool@gmail.com Reviewed-by: Zhu Yanjun Signed-off-by: Leon Romanovsky [bwh: Backported to 5.10: There was no assignment to init->attr.max_wr here; don't add it] Signed-off-by: Ben Hutchings Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/rxe_srq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_srq.c b/drivers/infiniband/sw/rxe/rxe_srq.c index 41b0d1e11bafdb..4e523d91e7dcb1 100644 --- a/drivers/infiniband/sw/rxe/rxe_srq.c +++ b/drivers/infiniband/sw/rxe/rxe_srq.c @@ -98,8 +98,6 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq *srq, return -ENOMEM; } - srq->rq.queue = q; - err = do_mmap_info(rxe, uresp ? &uresp->mi : NULL, udata, q->buf, q->buf_size, &q->ip); if (err) { @@ -116,6 +114,8 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq *srq, } } + srq->rq.queue = q; + return 0; } -- 2.53.0