From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E848C47D925; Tue, 16 Jun 2026 18:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635505; cv=none; b=YRE9DoD2O+cHEr/wvaa0sY8DWTDThn9cYhi98Tv/UJFCJEP/N6AGBnzp2iDV58OaWUSK8nW1WoXv+Ad6ee56P4HPtP9PCfJDJYJF8Zana5+UU1IBI7B8qZzVa6Q09j68V66aK9zQj6agmcckAkOs4YIeOuD1BXpQbkQ9N+Y1Oqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635505; c=relaxed/simple; bh=L2U9BHZixmKxNFT9QxUdTsj+weKNsAcd1peskNw+7ig=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VZCf7i7zD4Pq0f5Kogyv72cfKAyDMTHBdHBiuQlFoShvURBJHUJeIqJ+yimnG13oLdv02W7DbqGxfIFaJW+W+OQBFIok4Zk0cddBgqJENwMVg6+EDAfjqic0w5DZVsVAyhhiSPAOatZ7KPPXf4LkjlprQEwW9vKSegiGOcC7RS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1LAuCoKh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1LAuCoKh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 336FF1F000E9; Tue, 16 Jun 2026 18:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781635503; bh=461v5Yhs4SZp0vHkmwkl99f0HGKJvBALRMirH3SAa4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1LAuCoKhD9HhtC53Ud6IYMazwo/e41UrEdfU3DN6Z5EPzBWP+8AYgxmK8ewDEanyx m+/YG4y93S/1RHyEpzPodRNtg5WbuUCDdfrKSv1z6WbvIkwJ0g83gQ8rFHlwxbY1T0 THje8CdEoccpIJdoF6Qmfw/P0kFxTmAJ+Z5Yb0Vc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Salah Triki , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.10 062/342] iio: temperature: tsys01: fix broken PROM checksum validation Date: Tue, 16 Jun 2026 20:25:58 +0530 Message-ID: <20260616145051.148691931@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Salah Triki commit 4701e471c16866e7aa8f5e6a3a6b0d31e097e2c9 upstream. The current implementation of tsys01_crc_valid() incorrectly sums the first word (n_prom[0]) repeatedly instead of iterating over the 8 words retrieved from the PROM. This leads to a checksum mismatch and probe failure on hardware. According to the TSYS01 datasheet, the PROM consists of 8 words. A valid check must iterate through all 8 words to verify the integrity of the calibration data. The current driver only checks the first word 8 times. Note: This fix was identified during a code audit and is based on datasheet specifications. It has not been tested on real hardware. Fixes: 43e53407f680 ("Add tsys01 meas-spec driver support") Signed-off-by: Salah Triki Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/temperature/tsys01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/temperature/tsys01.c +++ b/drivers/iio/temperature/tsys01.c @@ -119,7 +119,7 @@ static bool tsys01_crc_valid(u16 *n_prom u8 sum = 0; for (cnt = 0; cnt < TSYS01_PROM_WORDS_NB; cnt++) - sum += ((n_prom[0] >> 8) + (n_prom[0] & 0xFF)); + sum += ((n_prom[cnt] >> 8) + (n_prom[cnt] & 0xFF)); return (sum == 0); }