From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0592143D4E8; Tue, 16 Jun 2026 18:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635700; cv=none; b=fpv+YG+pHGe18N9oVcXF1YR650YVfHD2cc3f2XQQaP+rT5uSPI0aot+DWTynNo2aO97Amny2d61pf4a5weQ9osPjXYXfHhQKatyxGSnZTdkEEwYTMHmv0CWo4T6ASh2omLVGYzM1owi7ILL6SkluJgn6H+wkj5EeIa4i42XJzxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635700; c=relaxed/simple; bh=L5v5wTHXHDq6huDMzcbZj5af4OABR4peBxI8x85CakU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LwUbJyZS1cXU9g8eguyGie+RBckuTTfEJBHUAHxyQUjh/8NpapZZ79FbhTQGB3Jv8t7dMH4DVhsPNuNQe7txB/cOs9Su67vZlckkSR7tImWMED905PcMReaa0LIeqkSmQnKQewxFKNCMhmGX2P8F4NHrYo1yVHtVELbEEDuLNgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bK3L/ohw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bK3L/ohw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E30E41F000E9; Tue, 16 Jun 2026 18:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781635698; bh=cZkbi8S5bAx18jOM6iIGsb2pnR01OxOxCgfwTXj/kRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bK3L/ohw64TLuZPjZ1DJTsPu/df3RawrD7L/rXbjHE16llmlePj+bvMu3yPg1y2Us oRxhbQLTEZ7ShHHs6pPAlb75DFfR1Ob31pobQLGyG5SH1q05p16jA89xak1NLH8Ldh ELk04WPJIeDZ6pii65rGN6KkFPj05oLl9bK3r5OI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Cen , Johan Hovold Subject: [PATCH 5.10 099/342] USB: serial: belkin_sa: validate interrupt status length Date: Tue, 16 Jun 2026 20:26:35 +0530 Message-ID: <20260616145052.843945098@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Cen commit 4ce058df2ee02cc2a0f0fd5cd64ce6f1482a0b65 upstream. The Belkin interrupt callback treats interrupt data as a four-byte status report and reads LSR/MSR fields at offsets 2 and 3. The interrupt-in buffer length is derived from endpoint wMaxPacketSize, and short interrupt transfers may complete successfully with a smaller actual_length. Check the completed interrupt packet length before parsing status fields so short interrupt endpoints and short successful packets are ignored instead of causing out-of-bounds or stale status-byte reads. KASAN report as below: BUG: KASAN: slab-out-of-bounds in belkin_sa_read_int_callback() Read of size 1 Call trace: belkin_sa_read_int_callback() (drivers/usb/serial/belkin_sa.c:202) __usb_hcd_giveback_urb() (drivers/usb/core/hcd.c:1630) dummy_timer() (?:?) Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Assisted-by: Codex:gpt-5.5 Signed-off-by: Zhang Cen Cc: stable@vger.kernel.org Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/belkin_sa.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/serial/belkin_sa.c +++ b/drivers/usb/serial/belkin_sa.c @@ -196,6 +196,9 @@ static void belkin_sa_read_int_callback( usb_serial_debug_data(&port->dev, __func__, urb->actual_length, data); + if (urb->actual_length < BELKIN_SA_MSR_INDEX + 1) + goto exit; + /* Handle known interrupt data */ /* ignore data[0] and data[1] */