From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E4A43D4E8; Tue, 16 Jun 2026 18:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635873; cv=none; b=hlBVLT9xIAtxbDiy4+mK2+Vu0equMeoor1QEvX+XOKoP8YecglgelllRTtKEIMUOgzZwZrTUEPg3/c30RQ2WeZWetTja/O2ZNfd1PiKgeSaa/+md04p+sxtUfAPsqQniYwn0Yg/MROyupOdvZUm8qXJnskwyrMXFAkp6j479IOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635873; c=relaxed/simple; bh=QqQUArD9C4NxzZP4uuAz8Djq+E07nzWF1PeuW99vNy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RGdzDjANp5m3FiZjFhzy+WVJ01sKAGJ1xdwRqeDRiaRSnwHOnUUFnTVXKNXHA+62XWrSgTWzIJCxYWXW++vwF2ve96PX8VPBZkRWpMx50AMshzu8XVu8mPvGHnryCoPxRSgp51KOkYk/TV8zjaCD3wo0NFWrLuDqVN5cDYx36xM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QvwTh5Rk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QvwTh5Rk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C7A11F000E9; Tue, 16 Jun 2026 18:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781635871; bh=RDZl7FwlaZo+Be1woS3i8G4fcm0JGZx1zD4B5nd3ERA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QvwTh5RkM8825EcGuO8UAjP2vf3xWGm70eCjsA3FpOZAJBXMYrWJF5yAxiDOrqIej m31dczoe7t8wVLiPZSFNdtFzipve9eGpIrjobGhOUc1ghlSc0k/WYE3esaRA1eblxQ TIOID4d6K+9oxYkIp15GGB4gQNqMWwDkWGQJ5uig= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fernando Fernandez Mancera , Florian Westphal , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.10 132/342] netfilter: xt_NFQUEUE: prefer raw_smp_processor_id Date: Tue, 16 Jun 2026 20:27:08 +0530 Message-ID: <20260616145054.346251048@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fernando Fernandez Mancera [ Upstream commit c6c5327dd18bec1e1bbf139b2cf5ae53608a9d30 ] With PREEMPT_RCU this triggers a splat because smp_processor_id() can be preempted while inside a RCU critical section. If xt_NFQUEUE target is invoked via nft_compat_eval() path, we are inside a RCU critical section. Just use the raw version instead. Fixes: 0ca743a55991 ("netfilter: nf_tables: add compatibility layer for x_tables") Signed-off-by: Fernando Fernandez Mancera Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/xt_NFQUEUE.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/xt_NFQUEUE.c b/net/netfilter/xt_NFQUEUE.c index 466da23e36ff47..b32d153e3a1862 100644 --- a/net/netfilter/xt_NFQUEUE.c +++ b/net/netfilter/xt_NFQUEUE.c @@ -91,7 +91,7 @@ nfqueue_tg_v3(struct sk_buff *skb, const struct xt_action_param *par) if (info->queues_total > 1) { if (info->flags & NFQ_FLAG_CPU_FANOUT) { - int cpu = smp_processor_id(); + int cpu = raw_smp_processor_id(); queue = info->queuenum + cpu % info->queues_total; } else { -- 2.53.0