From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F9C03CC303; Tue, 16 Jun 2026 18:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636136; cv=none; b=c2HyTwWbE8Ekt79RaWxayerpQCk5CDq3VN3xW088C6ybNnK1aj7t3hEfTOaCSX0GaEjDz9EcD0IV76UhKhPE2xg/rPXApj7/gAL9Lpaw0YO70UBVVo5jY9jXN4L8P5JEei1XOGTZTKOxdGH/BDWNwy9JJHKQhH5Kfnevp0AuDtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636136; c=relaxed/simple; bh=zug2u4OgbusOVe/LI5mTSE+WPuc1MTZ1ZxCD2PBFJug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PQ7YWsPJVCQLMIaQ0siJ2pNWWQWkxmA+iF75hfpAhOqZRk0ocoSDwpsd2vEO2WdAXmde0T+p5InwH39HkJNSd9dQZ7w5O9gdELWWFy+pbaR2q8OGnmwnyFpmaw0tZpumMu1R7luS9J06BzEly8gO7yAz+9oamAGQV1X4ly4YorQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=01WtmL8z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="01WtmL8z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAB531F000E9; Tue, 16 Jun 2026 18:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636134; bh=kcTjfRYY7rJ8r2l1cR+M1PW1lG6ych0wDlBaeuZNxO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=01WtmL8z02wghdaB14zckMzX1BIHRsN6wYYwYgjGzlAXIu1MwYC0VtZOQi+D3/6Q/ OvA2JXayZSrnUsBdN1qKTLCAX5/vVlT4TvPcbY5OdhtyJLCURzG3MsstGuHFcq9bu+ Hjk9EcJ2Y0z5EgywsePHiF5AipEvovST3MQkt0KI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Yuan Tan , Yifan Wu , Juefei Pu , Zhengchuan Liang , Xin Liu , Wyatt Feng , Ren Wei , Steffen Klassert Subject: [PATCH 5.10 181/342] xfrm: espintcp: do not reuse an in-progress partial send Date: Tue, 16 Jun 2026 20:27:57 +0530 Message-ID: <20260616145056.628925312@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wyatt Feng commit c381039ade2e161ab08c0eda73c4f8b9a7115928 upstream. espintcp keeps a single in-flight transmit in ctx->partial. Before building a new sk_msg, espintcp_sendmsg() first tries to flush that state through espintcp_push_msgs(). For blocking callers, espintcp_push_msgs() may return success even when the previous partial send is still pending. espintcp_sendmsg() would then reinitialize emsg->skmsg and reuse ctx->partial while the old transfer still owns that state. Do not rebuild the send message when ctx->partial is still in progress. If espintcp_push_msgs() returns with emsg->len still set, fail the new send instead of overwriting the live partial state. This is a memory-safety fix: reusing the live partial-send state can leave a stale offset attached to a new sk_msg and lead to an out-of- bounds read in the send path. tcp_sendmsg_locked() already handles waiting for send buffer memory, so the fix here is just to preserve espintcp's one-message-at-a-time transmit state. Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)") Cc: stable@kernel.org Reported-by: Yuan Tan Reported-by: Yifan Wu Reported-by: Juefei Pu Reported-by: Zhengchuan Liang Reported-by: Xin Liu Assisted-by: Codex:GPT-5.4 Signed-off-by: Wyatt Feng Signed-off-by: Ren Wei Signed-off-by: Steffen Klassert Signed-off-by: Greg Kroah-Hartman --- net/xfrm/espintcp.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/net/xfrm/espintcp.c +++ b/net/xfrm/espintcp.c @@ -340,6 +340,10 @@ static int espintcp_sendmsg(struct sock err = -ENOBUFS; goto unlock; } + if (emsg->len) { + err = -ENOBUFS; + goto unlock; + } sk_msg_init(&emsg->skmsg); while (1) {