From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 149D43DDDD5; Tue, 16 Jun 2026 19:07:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636872; cv=none; b=u0A7gunFWI3y5HlqQ2et/GxofCeyW9LpOnaLq5Uf0ddt9V8rtq4OZ57pitRBJnxkpE2HLcwm6OQLgDoJOwAbfbsIgfdG+o3iVKM85InVikEULXUF7cEz8EBtiFSUPhVdTWk9qT4xXHx6BJ+mf4JEdHJ3f16jfR/Jamrk+AiEe10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636872; c=relaxed/simple; bh=A/dGUdOA9cQooHZuZ0FxYPyRvEwf/gPZBuTZTyQBi1M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YXbEei/bDlskaeYAjEcvoqq5rBE5Y4cNP20owx1UMtOefizrEVinpVdEG9MGeJb68Qj7/djTvWvsHiCxRmbeNm0eqnxsapasfOhM5DsKlEQE8YJj1f2YYg4wVtCzTKsIdeLZ4BQ1mwXuYuXMnhNWvA20NpnmQ+2kMnjaVSg+hSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SNfSxRJD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SNfSxRJD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2CEC1F000E9; Tue, 16 Jun 2026 19:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636870; bh=3zPrxUFglto4HvsiLlPfjI1/L0BuN8M8dvfo2vkX8uM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SNfSxRJDAFoiQwzci/1jPFAtqOQA4f40HFPB19yEC22wKVMdcrk0W6AlRActgFq6W WXGIqnO/eOZ/WbRB8PsDhuZ9gyjElL4rXLku/IxlJb1nd+SkTt/g6ZwH3d/gO0NUvP +odVODhU1LzQuxcI0/1wbV9TYzo87O18TznmMdaE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jose Ignacio Tornos Martinez , Jacob Keller , Michal Swiatkowski , Paul Menzel , Rafal Romanowski , Tony Nguyen , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 288/342] ice: fix VF queue configuration with low MTU values Date: Tue, 16 Jun 2026 20:29:44 +0530 Message-ID: <20260616145101.827178092@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jose Ignacio Tornos Martinez [ Upstream commit 3ba4dd024d26372733d1c02e13e076c6016e3320 ] The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes. The iavf driver calculates databuffer_size based on the MTU using: databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128) where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN). For MTU values below 871: MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected) MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted) The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of 68 bytes. I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations. Fixes: 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message") cc: stable@vger.kernel.org Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Jacob Keller Reviewed-by: Michal Swiatkowski Reviewed-by: Paul Menzel Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Link: https://patch.msgid.link/20260515182419.1597859-3-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c @@ -2990,7 +2990,7 @@ static int ice_vc_cfg_qs_msg(struct ice_ if (qpi->rxq.databuffer_size != 0 && (qpi->rxq.databuffer_size > ((16 * 1024) - 128) || - qpi->rxq.databuffer_size < 1024)) { + qpi->rxq.databuffer_size < 128)) { v_ret = VIRTCHNL_STATUS_ERR_PARAM; goto error_param; }