From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8619042EED7; Tue, 16 Jun 2026 15:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622750; cv=none; b=ImCnoPrQ4wmipP4cIBD4Cs/eckfnNLPoKJpYIwmv5mR+SeNemb8tXZSTavEPDJoXH4C0Y4PwS2k1K8iBQgjWQl8M6hQz6ZEmpVtvvHE/VRWjitMi9Pz27fisoMdd3bjWcgxcfrqxXwPuGNBo+4ABJXyFapZSVAsLIY4MQGLjvsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622750; c=relaxed/simple; bh=jmrA1oWT4QnYFlh7LRs6b9MQy4PDDvgFGNeil5rReEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K7fjN103oK1fpRIcdqg+Ybl3QRMwtRq9YgRfWTOphGtdHpONYZYEXtmKH8ezfVE0ELf71nJCURlckvBIMB0066SuJQX+OOcvHzkt+cW5EPNFSExVDsmewx08XBZ7QcL2U55gY9weaUDcAEi6+IdeoOjqziPe6p5sW7jgGQm29iY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qBC0vcoS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qBC0vcoS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 863FF1F000E9; Tue, 16 Jun 2026 15:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781622749; bh=5LtgJPTLNZlGMuFIDreLH5sYhG30GUdypSjtlRmeyJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qBC0vcoSuua1+C/IgC9UlgcM70cy8PUZpqP6uvl/X0TzhroKICyL6vCoCey3+SabR Q+09CY9Rj3Pa+Gk3zVGZlVzFRYUbOK9Wu/OfwZcW8f/Lt810PYz+grAu7JHtJhLbUb vflthmxmNIuF8qp/vRWrIoJ3dpDK3yluB0UYQG2U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Florian Westphal , Fernando Fernandez Mancera , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 7.0 022/378] netfilter: conntrack_irc: fix possible out-of-bounds read Date: Tue, 16 Jun 2026 20:24:13 +0530 Message-ID: <20260616145110.997551211@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145109.744539446@linuxfoundation.org> References: <20260616145109.744539446@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Florian Westphal [ Upstream commit 66eba0ffce3b7e11449946b4cbbef8ea36112f56 ] When parsing fails after we've matched the command string we should bail out instead of trying to match a different command. This helper should be deprecated, given prevalence of TLS I doubt it has any relevance in 2026. Fixes: 869f37d8e48f ("[NETFILTER]: nf_conntrack/nf_nat: add IRC helper port") Closes: https://sashiko.dev/#/patchset/20260525182924.28456-1-fw%40strlen.de Signed-off-by: Florian Westphal Reviewed-by: Fernando Fernandez Mancera Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_irc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_irc.c b/net/netfilter/nf_conntrack_irc.c index b8e6d724acd155..064df01953ebf7 100644 --- a/net/netfilter/nf_conntrack_irc.c +++ b/net/netfilter/nf_conntrack_irc.c @@ -209,7 +209,7 @@ static int help(struct sk_buff *skb, unsigned int protoff, if (parse_dcc(data, data_limit, &dcc_ip, &dcc_port, &addr_beg_p, &addr_end_p)) { pr_debug("unable to parse dcc command\n"); - continue; + goto out; } pr_debug("DCC bound ip/port: %pI4:%u\n", @@ -223,7 +223,7 @@ static int help(struct sk_buff *skb, unsigned int protoff, net_warn_ratelimited("Forged DCC command from %pI4: %pI4:%u\n", &tuple->src.u3.ip, &dcc_ip, dcc_port); - continue; + goto out; } exp = nf_ct_expect_alloc(ct); -- 2.53.0