From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A03E01A682B; Tue, 16 Jun 2026 15:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781623781; cv=none; b=Wnf4h6ctlDrjxTm3nITNh3wlgEqu8xKtm/4TBEXLMMp7DH17ctSIpv4pPe/a0NoSXOXWOpnxrNXvwkIfM0uiyRUnBXMCjVws+w/VONd82f+VSbe4H731Nj4aRepXnGkZ5cZrIZr8IPYEk7UZl0yy/PFVT4ADjiYeSRUFvqrbnDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781623781; c=relaxed/simple; bh=lAgW3jhJyccY0Y5qAUF4rBCDelvWLcru86CP2eOirfo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RUhj2C7NEfpZ5ErwNyrlOEjm/nhtH1qpzDxydST53Io9dooW6YsvWkrszA6KYXTiDyaaxEUhNuR3im4qhEZ36q+AtNFWCTpJrKh42naQeFHWWlJ0TKZBlmW6lqnYjdGaml+4biWnt8vJKW5ddPSZkgDE9YGeOUYrfAQHhggF1sE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CAwdsqpN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CAwdsqpN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6E211F000E9; Tue, 16 Jun 2026 15:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781623780; bh=4YYTgiD1ALDj6Qo66nA5YXSxqDlMKFux7vBOnckYA14=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CAwdsqpNRIspYgpq04VJWTC9fU7N0H8IcbFjoBtKQ5trK+t40mYLCSIgAInvl6rIT Lf+NIjL0AQkK+7U72YeIC88kMXiW12bs6X5C29uue+dZb4unQd+hs3UH+X5BzJQieR Z5+PCUj5y0n+BqlGvb/Sufw1KwLqqKlWzEX5+2VA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Adrian Korwel , Johan Hovold Subject: [PATCH 7.0 207/378] USB: serial: io_ti: fix heap overflow in get_manuf_info() Date: Tue, 16 Jun 2026 20:27:18 +0530 Message-ID: <20260616145121.277183537@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145109.744539446@linuxfoundation.org> References: <20260616145109.744539446@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Adrian Korwel commit 183c1076eca43bbb3e7bdf597456f91d81c73e74 upstream. get_manuf_info() reads le16_to_cpu(rom_desc->Size) bytes from the device I2C EEPROM into a buffer allocated with kmalloc_obj(), which is sizeof(struct edge_ti_manuf_descriptor) = 10 bytes. The Size field comes from the device and is only validated (in check_i2c_image()) to make sure the descriptor fits within TI_MAX_I2C_SIZE (16384 bytes), not against the destination buffer size. A malicious USB device can therefore set Size to any value up to 16377, causing a heap overflow of up to 16367 bytes when plugged into a host running this driver. valid_csum() is called after read_rom() and also iterates buffer[0..Size-1], compounding the out-of-bounds access. Fix by rejecting descriptors with unexpected length before calling read_rom(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Adrian Korwel [ johan: amend commit message; also check for short descriptors ] Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/io_ti.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/usb/serial/io_ti.c +++ b/drivers/usb/serial/io_ti.c @@ -773,6 +773,12 @@ static int get_manuf_info(struct edgepor } /* Read the descriptor data */ + if (le16_to_cpu(rom_desc->Size) != sizeof(struct edge_ti_manuf_descriptor)) { + dev_err(dev, "unexpected Edge descriptor length: %u\n", + le16_to_cpu(rom_desc->Size)); + status = -EINVAL; + goto exit; + } status = read_rom(serial, start_address+sizeof(struct ti_i2c_desc), le16_to_cpu(rom_desc->Size), buffer); if (status)