From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A7D342519; Thu, 2 Jul 2026 16:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009354; cv=none; b=PsvFO2UmhrdjcdK3sYCOVOAr9pKPChU9h7rEn/rAfwhOE7LuOz8quPMuW5j8UV+eoxFtwGSkF7HvESrRQtk2Dxm1ltknhNJRjrAOgsZLiSNVMINKxYY51QHqQLXq1SMT9X3UTCSbJMlKoZOyURGGdqAMwPVNEMmK1a5BG9Nxc6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009354; c=relaxed/simple; bh=IV7o2fnZ9M2vrjeFKu2t30fBhXn8V9BFEosWkCUtgH0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pqin9IX8qtTnl2LiCCT2pzR5KMxlR6WeLkuTWP9Cu35FBk5Gpn1/NostINtphOX+TwwH95MCuJ4KBSssKgwoUeVfMqhTakuuNnDf6TRUcNMnftQgUCilB5Q8S8pbLf0zHGf56/RmpDmvQ+Nrbq7BCgdHGgRq3UHrsrUH4zIoD1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FKtS7pLL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FKtS7pLL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2E331F000E9; Thu, 2 Jul 2026 16:22:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783009350; bh=xRIkWFlwBEJ+lzZgsyVcH7Fyb28se0xSRIzX6sNGhag=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FKtS7pLLlSH0Rkzt9Zz3ddeaht3dONQxWAb7+oMYeo//22Ypv/5KiCki0MJ+8Ng0c Bs+TdDrBO1T5n6+T+Ps3i7tL0PHZt8+g03axPRX+t8oOdFT6KlnaBhEsw5UZeKJTNN Vb8qdH7F2MJcm8+Ssy78lp3vpul8av25IFpdQh6o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Sven Eckelmann , Sasha Levin Subject: [PATCH 5.10 19/96] batman-adv: tt: reject oversized local TVLV buffers Date: Thu, 2 Jul 2026 18:19:11 +0200 Message-ID: <20260702155109.391073943@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702155108.949633242@linuxfoundation.org> References: <20260702155108.949633242@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sven Eckelmann commit 1e9fab756f8395096d5bba7be0c373c4c8f5d165 upstream. The commit 3a359bf5c61d ("batman-adv: reject oversized global TT response buffers") added a check to ensure that a global return buffer size can be stored in an u16. The same buffer handling also exists for the local data buffer but was not touched. A similar check should be also be in place for the local TVLV buffer. It doesn't have the similar attack surface because it is only generated from locally discovered MAC addresses but the dynamic nature could still cause temporarily to large buffers. Cc: stable@kernel.org Fixes: 7ea7b4a14275 ("batman-adv: make the TT CRC logic VLAN specific") [ Context ] Signed-off-by: Sven Eckelmann Signed-off-by: Sasha Levin --- net/batman-adv/translation-table.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index fa6dece492d3ab..fb51088494dcc6 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -943,12 +943,12 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, { struct batadv_tvlv_tt_vlan_data *tt_vlan; struct batadv_softif_vlan *vlan; + size_t change_offset; u16 num_vlan = 0; u16 vlan_entries = 0; u16 total_entries = 0; u16 tvlv_len; u8 *tt_change_ptr; - int change_offset; spin_lock_bh(&bat_priv->softif_vlan_list_lock); hlist_for_each_entry(vlan, &bat_priv->softif_vlan_list, list) { @@ -964,8 +964,10 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, if (*tt_len < 0) *tt_len = batadv_tt_len(total_entries); - tvlv_len = *tt_len; - tvlv_len += change_offset; + if (check_add_overflow(*tt_len, change_offset, &tvlv_len)) { + tvlv_len = 0; + goto out; + } *tt_data = kmalloc(tvlv_len, GFP_ATOMIC); if (!*tt_data) { -- 2.53.0