From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 880E63D9535; Thu, 2 Jul 2026 16:23:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009405; cv=none; b=NMidzQXoee7U7loMbwtZrAaOjyrkU3R1LDP8qkb68gjS4dmzo22WQc4IEVdYLK8ph2nTFWCe7QwWnYUHo3YdYw+2Pk6DCMbOCiUzOl3G3U5LgUH2GGzkef+0ILECk8KtahzmqGh5dxsRUurfCUePLjGPjhFXYg7okAXO49Grnts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783009405; c=relaxed/simple; bh=MyPG/60hgqx61qvSK2DqW3WBr+RblRuiC8FKRhFSrOQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X3JA1o4BRTOl1VaXPXyH8Ai98zMnkzzityAeXdgTIxXH/ndCC+Q0f9GCqDf66oJEe6IzSFAYejKo8woQOSW32PuWAMrS3hRedlu7JGkKk/YodOCUq2iPRWByg+Na9FrI/PPRgtsjg44vf+1aaA9SOhlBdkvsKgNO31x9BFTZKTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UheRmjhG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UheRmjhG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E46C61F00A3A; Thu, 2 Jul 2026 16:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783009400; bh=d054Fx/b2ZOIzTYIIIddVC/rlPmi/Tei9DBkKzEhOsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UheRmjhGcoC0dZr5rrRhvd/nPMAUQj6DMYVVm517qJKZRU5cyi9GE8VNLXKvRsFae /zskYpt9Mn7QRIBldtsRmvtDbcBCQ6S5L5o7NUSwdnsDYTB72zECb0kQLncOWjR8iK dECGu12EkP0aQPeP6q5K5e5234JZ0wXyu62npq3E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Sven Eckelmann , Sasha Levin Subject: [PATCH 5.10 36/96] batman-adv: tp_meter: initialize dec_cwnd explicitly Date: Thu, 2 Jul 2026 18:19:28 +0200 Message-ID: <20260702155109.745196340@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702155108.949633242@linuxfoundation.org> References: <20260702155108.949633242@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sven Eckelmann commit febfb1b86224489535312296ecfa3d4bf467f339 upstream. When batadv_tp_update_cwnd() is called, dec_cwnd is increased. But dec_cwnd is only initialixed (to 0) when a duplicate Ack was received or when cwnd is below the ss_threshold. Just initialize the cwnd during the initialization to avoid any potential access of uninitialized data. Cc: stable@kernel.org Fixes: 33a3bb4a3345 ("batman-adv: throughput meter implementation") Signed-off-by: Sven Eckelmann Signed-off-by: Sasha Levin --- net/batman-adv/tp_meter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c index 1699fb8f8c82d4..d8ad58ccef2608 100644 --- a/net/batman-adv/tp_meter.c +++ b/net/batman-adv/tp_meter.c @@ -1065,6 +1065,8 @@ void batadv_tp_start(struct batadv_priv *bat_priv, const u8 *dst, * soft_interface, hence its MTU */ tp_vars->cwnd = BATADV_TP_PLEN * 3; + tp_vars->dec_cwnd = 0; + /* at the beginning initialise the SS threshold to the biggest possible * window size, hence the AWND size */ -- 2.53.0